Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag agon-build with hash of the Dockerfile #19

Closed
markmandel opened this issue Dec 11, 2017 · 0 comments
Closed

Tag agon-build with hash of the Dockerfile #19

markmandel opened this issue Dec 11, 2017 · 0 comments
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here!
Milestone
0.1

Comments

@markmandel
Copy link
Member

Make the version tag of the agon-build image to be the hash of the Dockerfile. Right now it is 0.1 and if the Dockerfile every changes, it has to be manually rebuilt.

With the hash of the Dockerfile, if the Dockerfile ever changes, then it will automatically rebuild on each invocation.

This will also lend itself nicely to image caching when doing CI/CD
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! labels Dec 11, 2017
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Use a sha256 of Dockerfile for build-image
20f2365 
This change means that when the Dockerfile for the
build image changes, then the build image will automatically
rebuild for each developer.

This will be a nice setup for CI as well.

Closes #19
@markmandel markmandel mentioned this issue Dec 13, 2017
Merged
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.1 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here!
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@markmandel