Adding make file to generate allocation go from proto #1041

pooneh-m · 2019-09-05T07:05:28Z

The change is following the SDK generation Docker and make files and referencing build-sdk-images/tool/.. which should be refactored. Refactoring is not included in this PR to simplify the review.
issue: #597

agones-bot · 2019-09-05T07:21:21Z

Build Succeeded 👏

Build Id: 99b4dc9b-eec9-417a-ac77-d0389d63d315

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-58b5b4c
image: gcr.io/agones-images/agones-sdk:1.0.0-58b5b4c
image: gcr.io/agones-images/agones-ping:1.0.0-58b5b4c
Linux C++ SDK (build): agonessdk-1.0.0-58b5b4c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-58b5b4c.zip

A preview of the website (the last 30 builds are retained):

https://58b5b4c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-58b5b4c

pooneh-m · 2019-09-06T16:23:09Z

@markmandel can you please review?

agones-bot · 2019-09-06T18:46:05Z

Build Succeeded 👏

Build Id: 34922904-55b5-49a6-b58f-6317e31dfc3d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-3397ed8
image: gcr.io/agones-images/agones-sdk:1.0.0-3397ed8
image: gcr.io/agones-images/agones-ping:1.0.0-3397ed8
Linux C++ SDK (build): agonessdk-1.0.0-3397ed8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-3397ed8.zip

A preview of the website (the last 30 builds are retained):

https://3397ed8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-3397ed8

build/build-allocation-images/go/Dockerfile

build/includes/allocation.mk

agones-bot · 2019-09-06T21:57:25Z

Build Succeeded 👏

Build Id: 175d1e69-c3c1-40d6-9bc1-8c957b3a75be

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-9ea12c0
image: gcr.io/agones-images/agones-sdk:1.0.0-9ea12c0
image: gcr.io/agones-images/agones-ping:1.0.0-9ea12c0
Linux C++ SDK (build): agonessdk-1.0.0-9ea12c0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-9ea12c0.zip

A preview of the website (the last 30 builds are retained):

https://9ea12c0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-9ea12c0

agones-bot · 2019-09-06T22:00:08Z

Build Succeeded 👏

Build Id: 32600357-e949-4a8b-9408-6ef5818e8807

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-518062a
image: gcr.io/agones-images/agones-sdk:1.0.0-518062a
image: gcr.io/agones-images/agones-ping:1.0.0-518062a
Linux C++ SDK (build): agonessdk-1.0.0-518062a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-518062a.zip

A preview of the website (the last 30 builds are retained):

https://518062a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-518062a

agones-bot · 2019-09-09T21:06:28Z

Build Succeeded 👏

Build Id: 087667f0-5ab1-46aa-afe7-90c22ee95448

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-58dac75
image: gcr.io/agones-images/agones-sdk:1.0.0-58dac75
image: gcr.io/agones-images/agones-ping:1.0.0-58dac75
Linux C++ SDK (build): agonessdk-1.0.0-58dac75-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-58dac75.zip

A preview of the website (the last 30 builds are retained):

https://58dac75-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-58dac75

markmandel · 2019-09-20T12:41:06Z

Will jump on this next week, I know you are waiting on it 👍

markmandel · 2019-09-24T00:34:21Z

build/includes/allocation.mk

+
+# Generates grpc server and client for a single allocation, use ALLOCATION_FOLDER variable to specify the allocation folder.
+gen-allocation-grpc: COMMAND := gen
+gen-allocation-grpc: run-allocation-command


Should this run the container with gen.sh? Do we need all the searching functionality in run-allocation-command?

In this particular instance, it feels like it might be overkill? WDYT? Simpler may be better?

I simplified it.

agones-bot · 2019-10-08T00:40:35Z

Build Failed 😱

Build Id: a2443464-7bab-49c2-a44e-41480077e5ba

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-08T00:56:18Z

Build Succeeded 👏

Build Id: 3ea1dbc8-0cd9-4459-8085-e10525eb5e05

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-d0e6cae
image: gcr.io/agones-images/agones-sdk:1.1.0-d0e6cae
image: gcr.io/agones-images/agones-ping:1.1.0-d0e6cae
Linux C++ SDK (build): agonessdk-1.1.0-d0e6cae-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-d0e6cae.zip

A preview of the website (the last 30 builds are retained):

https://d0e6cae-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d0e6cae

roberthbailey · 2019-10-10T03:22:55Z

build/build-allocation-images/go/gen.sh

+go install -mod=vendor github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway
+go install -mod=vendor github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
+
+outputpath=./allocation/go


I think this should go under pkg/allocation/go. The generated code for sdk.proto doesn't live at the top level of the repo; it lives under the pkg directory.

Done. Thanks for the suggestion.

roberthbailey · 2019-10-10T03:24:55Z

build/build-allocation-images/go/gen.sh

+go install -mod=vendor github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
+
+outputpath=./allocation/go
+protopath=cmd/allocator/v1alpha1


I wouldn't have expected the proto source to be under cmd. The cmd directory should be for main program entry points, and the proto definition is something that generates shared code.

Now that we have multiple proto files, it seems like it would be nice to create a folder to hold them (e.g. proto/) at the root level. The proto file isn't being added in the change, so I don't want to block you from making progress, but I do think we should find it a better home.

I am addressing this comment in: #1041
I will update the protopath reference after the PR is merged.

build/build-allocation-images/go/Dockerfile

agones-bot · 2019-10-11T17:22:01Z

Build Succeeded 👏

Build Id: 3ec7480e-cb48-4425-9505-ecb2fc57ebc1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-e4f2ae2
image: gcr.io/agones-images/agones-sdk:1.1.0-e4f2ae2
image: gcr.io/agones-images/agones-ping:1.1.0-e4f2ae2
Linux C++ SDK (build): agonessdk-1.1.0-e4f2ae2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-e4f2ae2.zip

A preview of the website (the last 30 builds are retained):

https://e4f2ae2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e4f2ae2

agones-bot · 2019-10-11T17:55:29Z

Build Succeeded 👏

Build Id: 23384ec4-33e5-4649-b410-60b8cb4b7021

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-624d287
image: gcr.io/agones-images/agones-sdk:1.1.0-624d287
image: gcr.io/agones-images/agones-ping:1.1.0-624d287
Linux C++ SDK (build): agonessdk-1.1.0-624d287-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-624d287.zip

A preview of the website (the last 30 builds are retained):

https://624d287-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-624d287

agones-bot · 2019-10-14T20:08:21Z

Build Succeeded 👏

Build Id: ff0d29dd-b55f-4eb5-9530-5a1f48b3b84f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-ee8cafb
image: gcr.io/agones-images/agones-sdk:1.1.0-ee8cafb
image: gcr.io/agones-images/agones-ping:1.1.0-ee8cafb
Linux C++ SDK (build): agonessdk-1.1.0-ee8cafb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-ee8cafb.zip

A preview of the website (the last 30 builds are retained):

https://ee8cafb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-ee8cafb

google-oss-robot · 2019-10-14T23:04:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roberthbailey · 2019-10-14T23:05:04Z

/lgtm

agones-bot · 2019-10-14T23:33:28Z

Build Succeeded 👏

Build Id: 5f20e53c-5af9-4537-8cc6-278c0603cc0d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3c2624d
image: gcr.io/agones-images/agones-sdk:1.1.0-3c2624d
image: gcr.io/agones-images/agones-ping:1.1.0-3c2624d
Linux C++ SDK (build): agonessdk-1.1.0-3c2624d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3c2624d.zip

A preview of the website (the last 30 builds are retained):

https://3c2624d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1041/head:pr_1041 && git checkout pr_1041
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3c2624d

google-oss-robot requested review from jkowalski and joeholley September 5, 2019 07:05

google-oss-robot added the size/XXL label Sep 5, 2019

pooneh-m requested review from markmandel and removed request for jkowalski September 5, 2019 07:05

pooneh-m force-pushed the gen-grpc branch from 58b5b4c to 3397ed8 Compare September 6, 2019 18:29

markmandel reviewed Sep 6, 2019

View reviewed changes

build/build-allocation-images/go/Dockerfile Show resolved Hide resolved

build/includes/allocation.mk Outdated Show resolved Hide resolved

pooneh-m force-pushed the gen-grpc branch 2 times, most recently from 9ea12c0 to 518062a Compare September 6, 2019 21:43

pooneh-m force-pushed the gen-grpc branch from 518062a to 58dac75 Compare September 9, 2019 20:48

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 10, 2019

pooneh-m requested review from markmandel and removed request for joeholley September 13, 2019 21:37

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 17, 2019

markmandel reviewed Sep 24, 2019

View reviewed changes

pooneh-m force-pushed the gen-grpc branch 2 times, most recently from 9a61337 to d0e6cae Compare October 8, 2019 00:28

roberthbailey reviewed Oct 10, 2019

View reviewed changes

pooneh-m force-pushed the gen-grpc branch from d0e6cae to e4f2ae2 Compare October 11, 2019 16:54

pooneh-m force-pushed the gen-grpc branch from e4f2ae2 to 624d287 Compare October 11, 2019 17:26

pooneh-m mentioned this pull request Oct 14, 2019

Move allocation proto to root level proto #1110

Merged

Adding make file to generate allocation go from proto

ee8cafb

pooneh-m force-pushed the gen-grpc branch from 624d287 to ee8cafb Compare October 14, 2019 19:39

pooneh-m requested a review from roberthbailey October 14, 2019 20:10

roberthbailey approved these changes Oct 14, 2019

View reviewed changes

google-oss-robot assigned roberthbailey Oct 14, 2019

google-oss-robot added the lgtm label Oct 14, 2019

Merge branch 'master' into gen-grpc

3c2624d

google-oss-robot removed the lgtm label Oct 14, 2019

google-oss-robot added the lgtm label Oct 14, 2019

roberthbailey merged commit c05bc4e into googleforgames:master Oct 14, 2019

markmandel added this to the 1.1.0 milestone Oct 22, 2019

markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/feature New features for Agones labels Oct 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding make file to generate allocation go from proto #1041

Adding make file to generate allocation go from proto #1041

pooneh-m commented Sep 5, 2019 •

edited

Loading

agones-bot commented Sep 5, 2019

pooneh-m commented Sep 6, 2019

agones-bot commented Sep 6, 2019

agones-bot commented Sep 6, 2019

agones-bot commented Sep 6, 2019

agones-bot commented Sep 9, 2019

markmandel commented Sep 20, 2019

markmandel Sep 24, 2019

pooneh-m Oct 8, 2019

agones-bot commented Oct 8, 2019

agones-bot commented Oct 8, 2019

roberthbailey Oct 10, 2019

pooneh-m Oct 10, 2019

roberthbailey Oct 10, 2019

pooneh-m Oct 14, 2019

pooneh-m Oct 14, 2019

agones-bot commented Oct 11, 2019

agones-bot commented Oct 11, 2019

agones-bot commented Oct 14, 2019

google-oss-robot commented Oct 14, 2019

roberthbailey commented Oct 14, 2019

agones-bot commented Oct 14, 2019

Adding make file to generate allocation go from proto #1041

Adding make file to generate allocation go from proto #1041

Conversation

pooneh-m commented Sep 5, 2019 • edited Loading

agones-bot commented Sep 5, 2019

pooneh-m commented Sep 6, 2019

agones-bot commented Sep 6, 2019

agones-bot commented Sep 6, 2019

agones-bot commented Sep 6, 2019

agones-bot commented Sep 9, 2019

markmandel commented Sep 20, 2019

markmandel Sep 24, 2019

Choose a reason for hiding this comment

pooneh-m Oct 8, 2019

Choose a reason for hiding this comment

agones-bot commented Oct 8, 2019

agones-bot commented Oct 8, 2019

roberthbailey Oct 10, 2019

Choose a reason for hiding this comment

pooneh-m Oct 10, 2019

Choose a reason for hiding this comment

roberthbailey Oct 10, 2019

Choose a reason for hiding this comment

pooneh-m Oct 14, 2019

Choose a reason for hiding this comment

pooneh-m Oct 14, 2019

Choose a reason for hiding this comment

agones-bot commented Oct 11, 2019

agones-bot commented Oct 11, 2019

agones-bot commented Oct 14, 2019

google-oss-robot commented Oct 14, 2019

roberthbailey commented Oct 14, 2019

agones-bot commented Oct 14, 2019

pooneh-m commented Sep 5, 2019 •

edited

Loading