Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WaitForEstablishedCRD into central crd package #108

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Move WaitForEstablishedCRD into central crd package #108

merged 1 commit into from
Feb 27, 2018

Conversation

markmandel
Copy link
Member

Make this reusable as we are adding more CustomResourceDefinitions

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 25, 2018
@markmandel markmandel added this to the 0.1 milestone Feb 25, 2018
cyriltovena
cyriltovena approved these changes Feb 27, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
Copy link
Collaborator

You need to merge master though

@markmandel
Move WaitForEstablishedCRD into central crd package
af9da96 
Make this reusable as we are adding more CustomResourceDefinitions
@markmandel markmandel merged commit 61af7cb into master Feb 27, 2018
@markmandel markmandel deleted the refactor/crd-established branch February 27, 2018 01:30
@markmandel markmandel mentioned this pull request May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@markmandel @cyriltovena