install.yaml now installs by default in agones-system #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… namespace to exists
|
Build Succeeded 👏 Build Id: 48be3563-5378-4247-b2fe-573b8dc13c94 The following development artifacts have been built, and will exist for the next 30 days:
|
cyriltovena
changed the title
markmandel
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue where the install.yaml now installs by default in the default namespace.
I've added the namespace everywhere in helm so when you use template it is explicitly set in every files and you can use kubectl apply on the resulting file without worrying about namespaces. In normal case this is not required but since we use template to generate the install.yaml it is better to do so. (This comes from the fact that the yaml works accross multiple namespace)
Unfortunately you need to create the namespace before and I've update the documentation accordingly and you can't use another namespace when using install.yaml unless you edit the file.
I think this is fine since if you want a quick testing setup you use the install.yaml but if you want more fine grained one, then helm is the way to go. (after all we're using a default values files for the install so it's already opinionated.)
Let me know WDYT.
PS: I've tested the quickstart on GKE with this new way to install and everything worked.