Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Add Trip Modal #44

Merged
merged 16 commits into from
Jul 16, 2020
Merged

Create Add Trip Modal #44

merged 16 commits into from
Jul 16, 2020

Conversation

zghera
Copy link
Collaborator

@zghera zghera commented Jul 9, 2020

What is a quick description of the change?

Added a modal for the add trips page. Trip data can be added and retrieved as a React ref upon submission of the form.

Is this fixing an issue?

fixes #43: Addresses the components that allow the user to enter trip data and retrieve that form data.

Are there more details that are relevant?

none

Check lists (check x in [ ] of list items)

  • [ ] Test written/updating
  • [ ] Tests passing
  • [ ] Coding style (indentation, etc)

This PR is purely for creating the UI components for the add trips page. A future PR will implement and test components to format/clean the inputted trip data and create a trip object.

Any additional comments?

GIF showing modal functionality:
Untitled_ Jul 10, 2020 2_46 PM

@zghera zghera changed the base branch from master to feed-trip-data-react July 9, 2020 20:26
Copy link
Collaborator

@anan-ya-y anan-ya-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pop-up looks really cool!

frontend/src/components/AddTrip/create-new-trip.js Outdated Show resolved Hide resolved
frontend/src/components/AddTrip/index.js Outdated Show resolved Hide resolved
frontend/src/components/AddTrip/index.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/index.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/index.js Show resolved Hide resolved
frontend/src/components/AddTrip/index.js Outdated Show resolved Hide resolved
@zghera zghera marked this pull request as ready for review July 13, 2020 22:17
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
@zghera zghera requested a review from keiffer01 July 14, 2020 17:32
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Show resolved Hide resolved
frontend/src/components/ViewTrips/add-trip.js Outdated Show resolved Hide resolved
@zghera zghera requested a review from HiramSilvey July 15, 2020 01:59
@zghera zghera self-assigned this Jul 15, 2020
Base automatically changed from feed-trip-data-react to master July 16, 2020 14:02
@zghera zghera merged commit 1780870 into master Jul 16, 2020
@zghera zghera deleted the create-add-trip-modal branch July 16, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Add Trips Functionality
4 participants