Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated targetSdk and compileSdk #1428

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Dec 6, 2023

The current PR updates targetSdk and compileSdk, to keep up with the latest Android version


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1427 🦕

@wangela
Copy link
Contributor

wangela commented Dec 6, 2023

Since the header-check detected missing license headers, we can use the addlicense tool to add those headers easily. Are you comfortable using this Go tool on your machine? Can defer this to a separate issue/PR if you want.

@kikoso
Copy link
Collaborator Author

kikoso commented Dec 6, 2023

Since the header-check detected missing license headers, we can use the addlicense tool to add those headers easily. Are you comfortable using this Go tool on your machine? Can defer this to a separate issue/PR if you want.

For sure, let me check this out.

@wangela
Copy link
Contributor

wangela commented Dec 6, 2023

Marking this chore to bundle it in with the other feat release.

@wangela wangela merged commit e6f8b8a into main Dec 6, 2023
11 checks passed
@wangela wangela deleted the feat/updated_target_and_compile_sdk branch December 6, 2023 21:20
kikoso added a commit that referenced this pull request Aug 14, 2024
* feat: updated targetSdk and compileSdk

* docs: added licenses

* docs: excluded markdown files from header check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update targetSdk = compileSdk = 34 for Maps and Places
2 participants