Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Data-Driven styling samples #1771

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Aug 26, 2024

The following PR adds the samples for the Data-Driven styling for datasets and boundaries.

Three source files have been added based on the documentation provided by the examples. The source file for Seattle no longer works, so the uploaded one is the file that worked when the documentation was written.

  • Two files are being created for the samples: DataDrivenDatasetStylingActivity and DataDrivenBoundariesActivity.
  • DataDrivenDatasetStylingActivity requires the user to replace YOUR-DATASET-ID with their dataset id.
  • Based on the documentation steps, the samples require a certain amount of work to get them working.

@kikoso kikoso changed the title Dataset Styling Samples feat: Dataset Styling Samples Aug 26, 2024
@kikoso kikoso force-pushed the feat/dataset_styling_samples branch from a172372 to b8a4697 Compare August 27, 2024 06:01
@kikoso kikoso marked this pull request as ready for review August 27, 2024 07:40
@kikoso kikoso changed the title feat: Dataset Styling Samples feat: Data-Driven styling samples Aug 27, 2024
@kikoso
Copy link
Collaborator Author

kikoso commented Aug 27, 2024

@stephenmcd , what do you think about uploading the source files for the datasets? They are publicly available in institutional sites and linked from our documentation, would it be ok to have them here on GitHub as well?

Copy link

snippet-bot bot commented Aug 28, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kikoso kikoso force-pushed the feat/dataset_styling_samples branch from d57783f to 5114122 Compare August 28, 2024 15:40
@kikoso kikoso force-pushed the feat/dataset_styling_samples branch from 10b4d45 to 1a097f6 Compare November 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants