Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #1687

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

teresarwqin
Copy link

Thank you for opening a Pull Request!

Remove EXCLUDE label
Set mapId value to DEMO_MAP_ID

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Remove EXCLUDE labels
Remove EXCLUDE label
Set mapId as DEMO_MAP_ID for demo purpose
Copy link
Contributor

@willum070 willum070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files in /dist are generated, so this change would be overwritten. You must make changes in js-samples/samples/. Edit this file: https://github.com/googlemaps/js-samples/blob/main/samples/place-text-search/index.ts

Just a note about EXCLUDE tags, I use custom map IDs for many example maps mostly to reduce POI noise. I know some internally don't prefer it, but I feel that the visual noise from extra POIs can impede understanding. Unfortunately the tag itself is not visually attractive, but that's a trade I'm willing to make for a much better looking map.

@teresarwqin
Copy link
Author

Thanks for the context.

The problem is the mapId is truncated on the dev site - https://developers.google.com/maps/documentation/javascript/place-search#maps_place_text_search-javascript
This is causing confusion to developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants