Skip to content

Commit

Permalink
Updated reviewer pool (GoogleCloudPlatform#6798)
Browse files Browse the repository at this point in the history
* Updated reviewer pool

* Removed megan from reviewer pool
  • Loading branch information
melinath authored and googlerjk committed Nov 25, 2022
1 parent f6e0fb8 commit 54f05dd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .ci/containers/contributor-checker/check-contributor.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ USER=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \

# This is where you add users who do not need to have an assignee chosen for
# them.
if $(echo $USER | fgrep -wq -e megan07 -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e SarahFrench); then
if $(echo $USER | fgrep -wq -e megan07 -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e SarahFrench -e roaks3); then
echo "User is on the list, not assigning."
exit 0
fi
Expand All @@ -40,7 +40,7 @@ else
# re-request review list
# only re-request reviews from previous reviewers who are on the random-assignee rotation.
# If you add people to the random-assignee rotation list below, please also add them to this list
if $(echo $reviewer | fgrep -wq -e rileykarson -e slevenick -e c2thorn -e melinath -e ScottSuarez -e shuyama1 -e megan07); then
if $(echo $reviewer | fgrep -wq -e rileykarson -e slevenick -e c2thorn -e melinath -e ScottSuarez -e shuyama1 -e megan07 -e roaks3); then
curl -H "Authorization: token ${GITHUB_TOKEN}" \
-d "$(jq -r --arg assignee "$reviewer" -n "{reviewers: [\$assignee], team_reviewers: []}")" \
"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/${PR_NUMBER}/requested_reviewers"
Expand All @@ -52,7 +52,7 @@ fi
# This is where you add people to the random-assignee rotation. This list
# might not equal the list of users who do not need to have an assigne.
# If you add people to this list, please also add them to the re-request review list above
ASSIGNEE=$(shuf -n 1 <(printf "rileykarson\nc2thorn\nslevenick\nscottsuarez\nshuyama1\nmegan07\nmelinath"))
ASSIGNEE=$(shuf -n 1 <(printf "rileykarson\nc2thorn\nslevenick\nscottsuarez\nshuyama1\nmelinath\nroaks3"))
comment=$(cat << EOF
Hello! I am a robot who works on Magic Modules PRs.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ USER=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \

# This image runs tests for community PRs. This script reverses check_membership.sh to exit without running tests
# for users for who tests are automatically run.
if $(echo $USER | fgrep -wq -e megan07 -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge); then
if $(echo $USER | fgrep -wq -e megan07 -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge -e roaks3); then
echo "User is on the list, skipping."
exit 0
else
Expand Down
2 changes: 1 addition & 1 deletion .ci/containers/terraform-vcr-tester/check_membership.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ USER=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \
"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/${pr_number}" | jq -r .user.login)

# Only run tests for safe users
if $(echo $USER | fgrep -wq -e megan07 -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge); then
if $(echo $USER | fgrep -wq -e megan07 -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge -e roaks3); then
echo "User is on the list, not skipping."
else
echo "Checking GCP org membership"
Expand Down

0 comments on commit 54f05dd

Please sign in to comment.