Added RationaleDialogCallback #208

ernestkamara · 2018-03-14T13:26:59Z

RationaleDialogCallback is an extension of PermissionCallbacks and forwards the rationale
dialog buttons click events to the host that requesting a permission(s). RationaleDialogCallback is useful for events logging and is completely optional.

Check out RationaleFragment in the sample app folder for example.

Merge easypermissions master into ernestkamara/master

samtstern · 2018-03-14T15:05:41Z

Hi @ernestkamara. Thanks for sending over a PR!

Can you explain the main use case for this callback? What situation do you have in your app where you want to know if the rationale was denied versus the actual permissions request?

ernestkamara · 2018-03-14T15:20:01Z

Hi @samtstern . We need this callback mainly for analytics logging to track how many denied the rationale dialog. We find this useful and might help us improve our rationale text and other UI states.

samtstern · 2018-03-14T15:34:24Z

Ok that's a reasonable use case. What about changing the design though:

Make RationaleDialogCallbacks its own interface, not an extension of PermissionCallbacks
Give it two methods:
- onRationaleAccepted(int requestCode)
- onRationaleDenied(int requestCode)
  - This will be called in addition to onPermissionDenied rather than instead of it.

ernestkamara · 2018-03-14T15:59:27Z

Ok. Thanks for your input. I will update it!

ernestkamara · 2018-03-14T17:01:29Z

PR updated @samtstern!

SUPERCILEX

@ernestkamara This looks great, thanks! I just have some code quality and README changes, but besides that, 👍.

SUPERCILEX · 2018-03-15T19:01:56Z

README.md

@@ -152,6 +152,33 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
 }
 ```

+### RationaleCallbacks


Nit: new line after. Also, how about calling it something like "Interacting with the rationale dialog"?

SUPERCILEX · 2018-03-15T19:02:42Z

README.md

+}
+```
+
+Check out [RationaleFragment](https://github.com/googlesamples/blob/master/app/src/main/java/pub/devrel/easypermissions/sample/RationaleFragment.java) in the sample app folder for the full example.


The link can be simplified to app/src/main/java/pub/devrel/easypermissions/sample/RationaleFragment.java. GitHub knows the project's directory structure. 👍

Also, it could be reworded to "For a full example, take a look at the sample RationaleFragment."

SUPERCILEX · 2018-03-15T19:03:20Z

README.md

+
+Note that permissions are not requested when the user denies or cancel the rationale dialog and `onPermissionsDenied` will be invoked.
+The user will need to reinvoke the function that requests permissions. This is callbacks can be useful for analytics tracking and UI states
+updates.


I'm not sure if we should give examples of how the callback can be used, thoughts @samtstern? Without that info, the paragraph can be simplified to "Rationale callbacks don't necessarily imply permission changes. To check for those, see the EasyPermissions.PermissionCallbacks."

SUPERCILEX · 2018-03-15T19:04:25Z

app/src/main/java/pub/devrel/easypermissions/sample/RationaleFragment.java

+    public View onCreateView(LayoutInflater inflater,
+                             ViewGroup container,
+                             Bundle savedInstanceState) {
+        super.onCreateView(inflater, container, savedInstanceState);


No need for this super call. 👍

SUPERCILEX · 2018-03-15T19:04:43Z

app/src/main/java/pub/devrel/easypermissions/sample/RationaleFragment.java

+                                                           EasyPermissions.RationaleCallbacks {
+    private static final String TAG = "RationaleFragment";
+    private static final int RC_STORAGE_PERM = 123;
+    public static final String PERMISSION_STORAGE =  Manifest.permission.WRITE_EXTERNAL_STORAGE;


This can be private.

SUPERCILEX · 2018-03-15T19:06:26Z

easypermissions/src/main/java/pub/devrel/easypermissions/EasyPermissions.java

+     */
+    public interface RationaleCallbacks {
+        void onRationaleAccepted(int requestCode);
+        void onRationaleDenied(int requestCode);


Nit: new line between these methods and none after.

SUPERCILEX · 2018-03-15T19:18:58Z

README.md

@@ -152,6 +152,33 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
 }
 ```

+### RationaleCallbacks
+Implement this callback if you want to interact with the rationale dialog.


Let's use the specific name, so something like "Implement the EasyPermissions.RationaleCallbacks if ..."

samtstern · 2018-03-15T19:32:23Z

app/src/main/java/pub/devrel/easypermissions/sample/RationaleFragment.java

+
+import java.util.List;
+
+public class RationaleFragment extends Fragment implements EasyPermissions.PermissionCallbacks,


Is there any need to introduce a whole new Fragment here rather than just adding this to the existing sample?

Would make the diff much smaller to just add the new callbacks to our existing sample code.

So, I added RationaleFragment in connection to my initial implementation of RationaleCallbacks which extends PermissionCallbacks. I guess it's not needed anymore. Thanks for your feedback @SUPERCILEX . Will update this PR shortly.

SUPERCILEX

Sweet! One last README comment.

SUPERCILEX · 2018-03-15T20:24:56Z

README.md


-```java
-public class RationaleFragment extends Fragment implements EasyPermissions.RationaleCallbacks {
+Implement the EasyPermissions.RationaleCallbacks if you want to interact with the rationale dialog.


nit: let's make it code font "`EasyPermissions.RationaleCallbacks`"

SUPERCILEX · 2018-03-15T20:25:06Z

README.md

-The user will need to reinvoke the function that requests permissions. This is callbacks can be useful for analytics tracking and UI states
-updates.
-
+Rationale callbacks don't necessarily imply permission changes. To check for those, see the EasyPermissions.PermissionCallbacks.


Same here: `...`.

samtstern · 2018-03-15T20:30:58Z

Thanks @SUPERCILEX for the review and @ernestkamara for the patient updates.

This is good to go. It also means the next release will be 1.2.0 since this is a new feature (woot!)

SUPERCILEX · 2018-03-15T20:31:18Z

README.md

@@ -170,7 +170,7 @@ public void onRationaleDenied(int requestCode) {
 }
 ```

-Rationale callbacks don't necessarily imply permission changes. To check for those, see the EasyPermissions.PermissionCallbacks.
+Rationale callbacks don't necessarily imply permission changes. To check for those, see the `EasyPermissions.RationaleCallbacks`.


Whoops, looks like this should stay PermissionCallbacks 😉

Smile.. Will create a new PR in a min!

Alrighty, go for it!

SUPERCILEX · 2018-03-15T20:31:51Z

@samtstern Or not 😆, PR incoming.

ernestkamara · 2018-03-15T20:42:07Z

Btw.. when is 1.2 scheduled?

samtstern · 2018-03-15T20:50:08Z

@ernestkamara just happened! https://github.com/googlesamples/easypermissions/releases/tag/1.2.0

Ana120914

Amor

Ernest Saidu Kamara and others added 2 commits March 14, 2018 10:10

Merge pull request #1 from googlesamples/master

a111ad1

Merge easypermissions master into ernestkamara/master

Added RationaleDialogCallbacks for rationale dialog buttons callbacks

4b3537b

Refactored RationaleCallbacks

54f5333

SUPERCILEX reviewed Mar 15, 2018

View reviewed changes

samtstern reviewed Mar 15, 2018

View reviewed changes

Clean up PR based on feedback

3309d6a

SUPERCILEX reviewed Mar 15, 2018

View reviewed changes

Added code font to EasyPermissions.RationaleCallbacks text

0e579b3

samtstern added this to the 1.1.4 milestone Mar 15, 2018

samtstern merged commit 20987dc into googlesamples:master Mar 15, 2018

SUPERCILEX reviewed Mar 15, 2018

View reviewed changes

Ana120914 reviewed Apr 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added RationaleDialogCallback #208

Added RationaleDialogCallback #208

ernestkamara commented Mar 14, 2018

samtstern commented Mar 14, 2018

ernestkamara commented Mar 14, 2018

samtstern commented Mar 14, 2018

ernestkamara commented Mar 14, 2018

ernestkamara commented Mar 14, 2018

SUPERCILEX left a comment

SUPERCILEX Mar 15, 2018

ernestkamara Mar 15, 2018

SUPERCILEX Mar 15, 2018

ernestkamara Mar 15, 2018

SUPERCILEX Mar 15, 2018

SUPERCILEX Mar 15, 2018

SUPERCILEX Mar 15, 2018

SUPERCILEX Mar 15, 2018

SUPERCILEX Mar 15, 2018

samtstern Mar 15, 2018

ernestkamara Mar 15, 2018

SUPERCILEX left a comment

SUPERCILEX Mar 15, 2018

SUPERCILEX Mar 15, 2018

samtstern commented Mar 15, 2018

SUPERCILEX Mar 15, 2018

ernestkamara Mar 15, 2018

SUPERCILEX Mar 15, 2018

SUPERCILEX commented Mar 15, 2018

ernestkamara commented Mar 15, 2018

samtstern commented Mar 15, 2018

Ana120914 left a comment


		import java.util.List;

		public class RationaleFragment extends Fragment implements EasyPermissions.PermissionCallbacks,

Added RationaleDialogCallback #208

Added RationaleDialogCallback #208

Conversation

ernestkamara commented Mar 14, 2018

samtstern commented Mar 14, 2018

ernestkamara commented Mar 14, 2018

samtstern commented Mar 14, 2018

ernestkamara commented Mar 14, 2018

ernestkamara commented Mar 14, 2018

SUPERCILEX left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SUPERCILEX left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern commented Mar 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SUPERCILEX commented Mar 15, 2018

ernestkamara commented Mar 15, 2018

samtstern commented Mar 15, 2018

Ana120914 left a comment

Choose a reason for hiding this comment