This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Differentiate between FragmentActivity and AppCompatActivity #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I826cdfca1e5ed0c33ebcba7314e3a41ddd0913b0
easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java
Show resolved
Hide resolved
easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java
Outdated
Show resolved
Hide resolved
easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java
Outdated
Show resolved
Hide resolved
easypermissions/src/main/java/pub/devrel/easypermissions/helper/PermissionHelper.java
Show resolved
Hide resolved
|
@samtstern LGTM. Just added a few minor suggestions to the PR. |
Change-Id: Ie03a23b5b04af5146b887101566d765315cad356
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266
@henriquenfaria what do you think?