Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print newly generated passwords by default #410

Closed
bumi opened this issue Oct 19, 2017 · 3 comments
Closed

Do not print newly generated passwords by default #410

bumi opened this issue Oct 19, 2017 · 3 comments
Labels

Comments

@bumi
Copy link

bumi commented Oct 19, 2017

Currently gopass generate prints the newly created password by default.
As this is sensitive data I think it should not be printed by default. We could add a flag (similar --clip) to additionally print the generate password.

The --force for generate (overwrite existing password) differs from show (display password). Maybe it would make sense to unify these?

@bumi bumi changed the title Do not print newly generated passwords Do not print newly generated passwords by default Oct 19, 2017
@dominikschulz
Copy link
Member

Actually I'd keep the default (to be discussed, but my preference), but add a flag to copy it to the clipboard.

@bumi
Copy link
Author

bumi commented Oct 24, 2017

The flag to copy it to the clipboard is already there, that works fine.

In my flow I dislike that coming back to the terminal after a few hours the password is still displayed and might get exposed.

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Oct 27, 2017
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Oct 27, 2017
@bumi
Copy link
Author

bumi commented Oct 27, 2017

awesome!
though actually I also would not default to copying the password to the clipboard on creation :)
but yeah it totally solves that the password gets accidentally exposed.

thanks for all the work! gopass is such a great and helpful piece of software!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants