Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use callback for printing update progress #1799

Closed
wants to merge 1 commit into from
Closed

Use callback for printing update progress #1799

wants to merge 1 commit into from

Conversation

dominikschulz
Copy link
Member

RELEASE_NOTES=n/a

Signed-off-by: Dominik Schulz [email protected]

@dominikschulz dominikschulz added the cleanup Code hygiene label Feb 14, 2021
@dominikschulz dominikschulz added this to the 1.12.1 milestone Feb 14, 2021
AnomalRoil
AnomalRoil previously approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it really increases readability or maintainability though.

@dominikschulz
Copy link
Member Author

Yes, sorry. Should have provided more context.
This was a first test to see if #1798 would be feasible.
Not sure if we should do that, but I wanted to give it a first try in a location where it doesn't hurt.

@dominikschulz
Use callback for printing update progress
26fc522 
RELEASE_NOTES=n/a

Signed-off-by: Dominik Schulz <[email protected]>
@dominikschulz dominikschulz marked this pull request as draft February 21, 2021 20:27
@dominikschulz dominikschulz modified the milestones: 1.12.1, 1.12.2 Feb 21, 2021
AnomalRoil
AnomalRoil approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's still in draft mode, why?

@dominikschulz
Copy link
Member Author

You have some concerns if this increases readability and I wanted to give it some more thought.

@dominikschulz dominikschulz modified the milestones: 1.12.2, 1.12.3 Mar 13, 2021
@dominikschulz dominikschulz modified the milestones: 1.12.3, 1.x.x, 1.12.4, 1.12.5 Mar 20, 2021
@AnomalRoil AnomalRoil modified the milestones: 1.12.5, 1.x.x Sep 29, 2021
@AnomalRoil AnomalRoil modified the milestones: 1.x.x, 1.14.0 Dec 21, 2021
@dominikschulz
Copy link
Member Author

This doesn't seem to help. Closing.

@dominikschulz dominikschulz deleted the feat/updcb branch December 23, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil approved these changes

Assignees
No one assigned
Labels
cleanup Code hygiene
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschulz @AnomalRoil