Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile to include BSD in crosscompile #2631

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Update Makefile to include BSD in crosscompile #2631

merged 1 commit into from
Aug 1, 2023

Conversation

dominikschulz
Copy link
Member

This should help to catch cross-platform issues before we attempt to build a release in the future.

@dominikschulz dominikschulz added the bug Defects label Jul 31, 2023
@dominikschulz dominikschulz added this to the 1.15.7 milestone Jul 31, 2023
@AnomalRoil
Copy link
Member

How about just running goreleaser build in our build GHA?

@dominikschulz
Copy link
Member Author

Doing a snapshot build is quite expensive. But it would be nice to trigger that before merging a release PR.
That would need some changes to the workflow configs but it should be possible.

@dominikschulz dominikschulz merged commit d8a01b5 into master Aug 1, 2023
8 checks passed
@dominikschulz dominikschulz deleted the dominikschulz-patch-1 branch August 1, 2023 08:05
@dominikschulz
Copy link
Member Author

Oh, I see. goreleaser build != goreleaser release --snapshot. That might actually work.

@AnomalRoil
Copy link
Member

I think it would. We'd just need to tell it to skip tag verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil approved these changes

Assignees
No one assigned
Labels
bug Defects
Projects
None yet
Milestone
1.15.7
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschulz @AnomalRoil