[feat] Add XCKD pwgen config options #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds three new config options to influence the default behaviour of the XKCD password generator. * pwgen.xkcd.sep for the word separator (string) * pwgen.xkcd.lang for the language (string) * pwgen.xkcd.len for the number of words (int) Signed-off-by: Dominik Schulz <[email protected]>
AnomalRoil
reviewed
Sep 7, 2023
There was a problem hiding this comment.
LGTM, but should we also change it here:
gopass/internal/action/generate.go
Lines 326 to 329 in 9666b0a
to not ask for the length when one is configured?
Also note that I think the gopass generate -g xkcd nameofentry command isn't affected by this change since it doesn't use xkcdGen:
gopass/internal/action/generate.go
Line 346 in 9666b0a
So this effectively only affects gopass pwgen which is arguably less useful than gopass generate, no?
Signed-off-by: Dominik Schulz <[email protected]>
Signed-off-by: Dominik Schulz <[email protected]>
orangekame3
added a commit
to orangekame3/gopass
that referenced
this pull request
Oct 4, 2023
This commit fixes golangci-lint error. ``` Signed-off-by: orangekame3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds three new config options to influence the default behaviour of the XKCD password generator.
Fixes #2595