Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix parsing of large secrets #2654

Merged
merged 1 commit into from
Sep 9, 2023
Merged

[bugfix] Fix parsing of large secrets #2654

merged 1 commit into from
Sep 9, 2023

Commits on Sep 9, 2023

  1. [bugfix] Fix parsing of large secrets 

    The AKV secret type does rely on the bufio.Scanner and that uses
a 64k limit by default. This change extends the limit to always
match the supplied input data. This might exceed the available
memory but not corrupt the output data.

If we want to support payloads larger than the available memory
we must make large changes to the parser. But since the issue
is quite severe and we don't advertise to support huge playloads
this seems to be a good compromise.

Fixes gopasspw#2594

Signed-off-by: Dominik Schulz <[email protected]>
    @dominikschulz
    dominikschulz committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    8a2872f View commit details
    Browse the repository at this point in the history