Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add new pwgen options to capitalize and include numbers in #2703

Merged
merged 3 commits into from
Nov 20, 2023
Merged

[feature] Add new pwgen options to capitalize and include numbers in #2703

merged 3 commits into from
Nov 20, 2023

Conversation

dominikschulz
Copy link
Member

xkcd style passwords.

Depends on martinhoefling/goxkcdpwgen#10

Fixes #2573

@dominikschulz dominikschulz added the feature Enhancements and new features label Nov 19, 2023
@dominikschulz dominikschulz added this to the 1.15.10 milestone Nov 19, 2023
@dominikschulz dominikschulz mentioned this pull request Nov 19, 2023
Closed
AnomalRoil
AnomalRoil previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I feel these kind of tweaks might benefit from having a config option to set the default value. WDYT?

AnomalRoil
AnomalRoil reviewed Nov 20, 2023
View reviewed changes
pkg/pwgen/xkcdgen/pwgen.go
g.SetCapitalize(delim == "")
g.SetCapitalize(delim == "" || capitalize)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that we already supported the feature when we set the delimiter the the empty string, nice.

@dominikschulz dominikschulz modified the milestones: 1.15.10, 1.15.11 Nov 20, 2023
@dominikschulz
Recommend bash-completion
a32fbb5 
Signed-off-by: Dominik Schulz <[email protected]>
@dominikschulz
Replace the goxkcdgenerator dependency with the fork until it is merged.
b11f698 
Also adds and fixes some config options related to the xkcd pwgen.

Signed-off-by: Dominik Schulz <[email protected]>
@dominikschulz dominikschulz merged commit 2e2fe82 into gopasspw:master Nov 20, 2023
6 of 8 checks passed
@dominikschulz dominikschulz deleted the fix/issue-2573 branch November 20, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil left review comments

@martinhoefling martinhoefling Awaiting requested review from martinhoefling

Assignees
No one assigned
Labels
feature Enhancements and new features
Projects
None yet
Milestone
1.15.11
Development

Successfully merging this pull request may close these issues.

[Feature Request] gopass pwgen -x should support more options/flags
2 participants
@dominikschulz @AnomalRoil