[BUGFIX] Use 'en' as default language for the xkcd generator #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2792 Signed-off-by: Yolan Romailler <[email protected]>
Signed-off-by: Yolan Romailler <[email protected]>
dominikschulz
approved these changes
Feb 10, 2024
|
@AnomalRoil I think it might be overkill to have defaults for everything pre-defined. The idea of the new config handlig to have a low bar for new options. And looking at the amount of changes in this CL alone that might be a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the xkcd language as a default.
Fixes #2792
Speaking of default config options: should we have explicit default values for all supported config options, so that users who run
gopass configwould see all possible config options?