Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a simple, robust and predictable KV parser #659

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

dominikschulz
Copy link
Member

@dominikschulz dominikschulz commented Feb 18, 2018

This commit replaces the YAML parser with a very simple key value parser that doesn't suffer from YAML's weaknesses.

Fixes #559
Fixes #638

@dominikschulz dominikschulz added the feature Enhancements and new features label Feb 18, 2018
@dominikschulz dominikschulz added this to the 1.x.x milestone Feb 18, 2018
@dominikschulz dominikschulz self-assigned this Feb 18, 2018
@dominikschulz dominikschulz force-pushed the feature/kv branch 3 times, most recently from d3ea135 to 5ea5326 Compare February 18, 2018 22:10
@codecov
Copy link

codecov bot commented Feb 18, 2018

Codecov Report

Merging #659 into master will increase coverage by 0.01%.
The diff coverage is 75.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage    64.5%   64.52%   +0.01%     
==========================================
  Files         142      143       +1     
  Lines        7950     7967      +17     
==========================================
+ Hits         5128     5140      +12     
- Misses       2202     2204       +2     
- Partials      620      623       +3
Impacted Files Coverage Δ
commands.go 83.47% <ø> (-0.28%) ⬇️
store/secret/secret.go 94.2% <72.73%> (+3.6%) ⬆️
store/secret/kv.go 75% <75%> (ø)
store/secret/yaml.go 76.6% <76.6%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5437118...de45b39. Read the comment docs.

@dominikschulz dominikschulz changed the title WIP: Implement a simple, robust and predictable KV parser Implement a simple, robust and predictable KV parser Feb 20, 2018
@dominikschulz
Copy link
Member Author

@notandy I used your code from #638 as a starting point and implemented a new K/V parser with YAML fallback support.

@martinhoefling This should cover #559 as well.

@notandy
Copy link

notandy commented Feb 21, 2018

@dominikschulz works well with gopass-bridge, thanks!

kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancements and new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants