Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Path to URL #698

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Conversation

dominikschulz
Copy link
Member

Fixes #677

@dominikschulz dominikschulz added the cleanup Code hygiene label Mar 4, 2018
@dominikschulz dominikschulz force-pushed the feature/issue-677 branch 3 times, most recently from 0e489f9 to 2e15fa1 Compare March 8, 2018 09:13
@dominikschulz dominikschulz changed the title WIP: Change Path to URL Change Path to URL Mar 8, 2018
@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #698 into master will decrease coverage by 0.46%.
The diff coverage is 63.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   64.87%   64.41%   -0.46%     
==========================================
  Files         144      150       +6     
  Lines        8255     8426     +171     
==========================================
+ Hits         5355     5427      +72     
- Misses       2252     2334      +82     
- Partials      648      665      +17
Impacted Files Coverage Δ
backend/crypto/gpg/cli/binary.go 80.95% <ø> (-1.66%) ⬇️
store/sub/recipients.go 55.22% <0%> (ø) ⬆️
backend/context.go 0% <0%> (ø)
backend/sync.go 100% <100%> (ø)
backend/store.go 100% <100%> (ø)
backend/crypto.go 100% <100%> (ø)
config/io.go 72.37% <100%> (-0.96%) ⬇️
config/legacy.go 100% <100%> (ø) ⬆️
store/sub/git.go 77.08% <100%> (ø) ⬆️
store/root/mount.go 52.22% <16.67%> (-6.6%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f967b...6094760. Read the comment docs.

@dominikschulz dominikschulz merged commit c0113f0 into gopasspw:master Mar 8, 2018
@dominikschulz dominikschulz deleted the feature/issue-677 branch March 8, 2018 09:59
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code hygiene
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant