Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite AutoSync and NoConfirm with sub store config #701

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

dominikschulz
Copy link
Member

Fixes #700

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #701 into master will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   64.45%   64.39%   -0.07%     
==========================================
  Files         150      150              
  Lines        8451     8446       -5     
==========================================
- Hits         5447     5438       -9     
- Misses       2338     2342       +4     
  Partials      666      666
Impacted Files Coverage Δ
context.go 71.43% <ø> (-8.57%) ⬇️
store/root/read.go 42.86% <0%> (-57.14%) ⬇️
store/root/mount.go 52.22% <100%> (ø) ⬆️
action/show.go 52.94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b11c57...3accce0. Read the comment docs.

@dominikschulz dominikschulz merged commit 7ab5453 into gopasspw:master Mar 8, 2018
@dominikschulz dominikschulz deleted the fix/issue-700 branch March 8, 2018 15:27
dominikschulz pushed a commit that referenced this pull request Mar 9, 2018
* Fixes #667 and correct a few details

This primarily adds the config option requested in #667.
I've added back the notion or erroring in case of a show action on an
entry with only a password and the safe content option enabled
Also I've fixed the way the String() function of the StoreConfig forgot
to display the Notification value in its output.

* Adding tests for autoclip

* adding a clip flag back

* correcting an old copy-paste mistake

* trying to correct the problem

* Correcting the error caused by #701
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
* Fixes gopasspw#667 and correct a few details

This primarily adds the config option requested in gopasspw#667.
I've added back the notion or erroring in case of a show action on an
entry with only a password and the safe content option enabled
Also I've fixed the way the String() function of the StoreConfig forgot
to display the Notification value in its output.

* Adding tests for autoclip

* adding a clip flag back

* correcting an old copy-paste mistake

* trying to correct the problem

* Correcting the error caused by gopasspw#701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant