forked from gojek/proctor
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Jasoet] feat(metadata): Show jobs list now depends on user's authent…
…ication group
- Loading branch information
Showing
5 changed files
with
174 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,15 @@ package handler | |
|
||
import ( | ||
"bytes" | ||
"context" | ||
"encoding/json" | ||
"errors" | ||
"fmt" | ||
"net/http" | ||
"net/http/httptest" | ||
metadataRepository "proctor/internal/app/service/metadata/repository" | ||
"proctor/internal/app/service/security/middleware" | ||
"proctor/pkg/auth" | ||
"testing" | ||
|
||
"proctor/internal/pkg/model/metadata/env" | ||
|
@@ -121,10 +124,20 @@ func (s *MetadataHandlerTestSuite) TestHandleBulkDisplay() { | |
t := s.T() | ||
|
||
req := httptest.NewRequest("GET", "/metadata", bytes.NewReader([]byte{})) | ||
groups := []string{"admin", "migratior"} | ||
userDetail := &auth.UserDetail{ | ||
Name: "jasoet", | ||
Email: "[email protected]", | ||
Active: true, | ||
Groups: groups, | ||
} | ||
|
||
ctx := context.WithValue(req.Context(), middleware.ContextUserDetailKey, userDetail) | ||
req = req.WithContext(ctx) | ||
responseRecorder := httptest.NewRecorder() | ||
|
||
jobsMetadata := []modelMetadata.Metadata{} | ||
s.mockRepository.On("GetAll").Return(jobsMetadata, nil).Once() | ||
var jobsMetadata []modelMetadata.Metadata | ||
s.mockRepository.On("GetAllByGroups", groups).Return(jobsMetadata, nil).Once() | ||
|
||
s.metadataHTTPHandler.GetAll()(responseRecorder, req) | ||
|
||
|
@@ -141,10 +154,20 @@ func (s *MetadataHandlerTestSuite) TestHandleBulkDisplayStoreFailure() { | |
t := s.T() | ||
|
||
req := httptest.NewRequest("GET", "/metadata", bytes.NewReader([]byte{})) | ||
groups := []string{"admin", "migratior"} | ||
userDetail := &auth.UserDetail{ | ||
Name: "jasoet", | ||
Email: "[email protected]", | ||
Active: true, | ||
Groups: groups, | ||
} | ||
|
||
ctx := context.WithValue(req.Context(), middleware.ContextUserDetailKey, userDetail) | ||
req = req.WithContext(ctx) | ||
responseRecorder := httptest.NewRecorder() | ||
|
||
jobsMetadata := []modelMetadata.Metadata{} | ||
s.mockRepository.On("GetAll").Return(jobsMetadata, errors.New("error")).Once() | ||
s.mockRepository.On("GetAllByGroups", groups).Return(jobsMetadata, errors.New("error")).Once() | ||
|
||
s.metadataHTTPHandler.GetAll()(responseRecorder, req) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,6 +113,84 @@ func (s *MetadataRepositoryTestSuite) TestGetAllFailure() { | |
s.mockRedisClient.AssertExpectations(t) | ||
} | ||
|
||
func (s *MetadataRepositoryTestSuite) TestGetAllByGroups() { | ||
t := s.T() | ||
|
||
metadata1 := modelMetadata.Metadata{ | ||
Name: "job1", | ||
ImageName: "job1-image-name", | ||
Description: "desc1", | ||
Author: "Test User<[email protected]", | ||
Contributors: "Test User<[email protected]", | ||
Organization: "Test Org", | ||
AuthorizedGroups: []string{"group_one", "group_two", "group_three", "group_four"}, | ||
} | ||
|
||
metadata2 := modelMetadata.Metadata{ | ||
Name: "job2", | ||
ImageName: "job2-image-name", | ||
Description: "desc2", | ||
Author: "Test User 2<[email protected]", | ||
Contributors: "Test User 2<[email protected]", | ||
Organization: "Test Org2", | ||
AuthorizedGroups: []string{"group_x", "group_y", "group_z", "group_a"}, | ||
} | ||
|
||
metadata3 := modelMetadata.Metadata{ | ||
Name: "job3", | ||
ImageName: "job3-image-name", | ||
Description: "desc3", | ||
Author: "Test User 3<[email protected]", | ||
Contributors: "Test User 3<[email protected]", | ||
Organization: "Test Org3", | ||
} | ||
|
||
s.mockRedisClient.On("KEYS", "*-metadata").Return( | ||
[]string{"job1-metadata", "job2-metadata", "job3-metadata"}, nil).Times(5) | ||
|
||
jsonMetadata1, err := json.Marshal(metadata1) | ||
assert.NoError(t, err) | ||
jsonMetadata2, err := json.Marshal(metadata2) | ||
assert.NoError(t, err) | ||
jsonMetadata3, err := json.Marshal(metadata3) | ||
assert.NoError(t, err) | ||
values := [][]byte{jsonMetadata1, jsonMetadata2, jsonMetadata3} | ||
|
||
keys := []string{"job1-metadata", "job2-metadata", "job3-metadata"} | ||
jobKeys := make([]interface{}, len(keys)) | ||
for i := range keys { | ||
jobKeys[i] = keys[i] | ||
} | ||
|
||
s.mockRedisClient.On("MGET", jobKeys...).Return(values, nil).Times(5) | ||
|
||
metadataSlice1, err := s.testMetadataStore.GetAllByGroups([]string{"group_two", "group_a"}) | ||
assert.NoError(t, err) | ||
|
||
assert.EqualValues(t, []modelMetadata.Metadata{metadata1, metadata2, metadata3}, metadataSlice1) | ||
|
||
metadataSlice2, err := s.testMetadataStore.GetAllByGroups([]string{"group_two"}) | ||
assert.NoError(t, err) | ||
|
||
assert.EqualValues(t, []modelMetadata.Metadata{metadata1,metadata3}, metadataSlice2) | ||
|
||
metadataSlice3, err := s.testMetadataStore.GetAllByGroups([]string{"group_a"}) | ||
assert.NoError(t, err) | ||
|
||
assert.EqualValues(t, []modelMetadata.Metadata{metadata2,metadata3}, metadataSlice3) | ||
|
||
metadataSlice4, err := s.testMetadataStore.GetAllByGroups([]string{"group_a", "group_x"}) | ||
assert.NoError(t, err) | ||
|
||
assert.EqualValues(t, []modelMetadata.Metadata{metadata2,metadata3}, metadataSlice4) | ||
|
||
metadataSlice5, err := s.testMetadataStore.GetAllByGroups([]string{"groupz", "group3"}) | ||
assert.NoError(t, err) | ||
|
||
assert.EqualValues(t, []modelMetadata.Metadata{metadata3}, metadataSlice5) | ||
s.mockRedisClient.AssertExpectations(t) | ||
} | ||
|
||
func (s *MetadataRepositoryTestSuite) TestGetAllMgetFailure() { | ||
t := s.T() | ||
|
||
|