[hadrian.siregar|bimo.horizon] Inject user email to execution argumen…

…t in execution post handler
gopaytech · Oct 11, 2019 · d12c05b · d12c05b
1 parent 27ef13f
commit d12c05b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/internal/app/service/execution/handler/http.go b/internal/app/service/execution/handler/http.go
@@ -20,6 +20,7 @@ import (
 	"proctor/internal/app/service/infra/config"
 	"proctor/internal/app/service/infra/logger"
 	serviceNotification "proctor/internal/app/service/notification/service"
+	"proctor/internal/pkg/constant"
 	"proctor/internal/pkg/model/execution"
 	"proctor/pkg/notification/event"
 )
@@ -155,10 +156,10 @@ func (httpHandler *executionHTTPHandler) GetStatus() http.HandlerFunc {
 
 		response.WriteHeader(http.StatusOK)
 
-		responseJson, err := json.Marshal(responseBody)
+		responseJSON, err := json.Marshal(responseBody)
 		logger.LogErrors(err, "marshal json from: ", responseBody)
 
-		_, _ = response.Write(responseJson)
+		_, _ = response.Write(responseJSON)
 
 	}
 }
@@ -179,6 +180,7 @@ func (httpHandler *executionHTTPHandler) Post() http.HandlerFunc {
 			_, _ = response.Write([]byte(status.MalformedRequest))
 			return
 		}
+		job.Args[constant.AuthorEmailKey] = userEmail
 
 		context, executionName, err := httpHandler.service.Execute(job.Name, userEmail, job.Args)
 
@@ -205,10 +207,10 @@ func (httpHandler *executionHTTPHandler) Post() http.HandlerFunc {
 
 		response.WriteHeader(http.StatusCreated)
 
-		responseJson, err := json.Marshal(responseBody)
+		responseJSON, err := json.Marshal(responseBody)
 		logger.LogErrors(err, "marshal json from: ", responseBody)
 
-		_, _ = response.Write(responseJson)
+		_, _ = response.Write(responseJSON)
 		return
 	}
 }
diff --git a/internal/app/service/execution/handler/http_test.go b/internal/app/service/execution/handler/http_test.go
@@ -261,7 +261,10 @@ func (suite *ExecutionHTTPHandlerTestSuite) TestSuccessfulJobExecutionPostHTTPHa
 	userEmail := "[email protected]"
 	job := parameter.Job{
 		Name: "sample-job-name",
-		Args: map[string]string{"argOne": "sample-arg"},
+		Args: map[string]string{
+			"argOne": "sample-arg",
+			"AUTHOR": userEmail,
+		},
 	}
 	context := &model.ExecutionContext{
 		UserEmail: userEmail,
@@ -321,7 +324,10 @@ func (suite *ExecutionHTTPHandlerTestSuite) TestGenericErrorJobExecutionPostHTTP
 	userEmail := "[email protected]"
 	job := parameter.Job{
 		Name: "sample-job-name",
-		Args: map[string]string{"argOne": "sample-arg"},
+		Args: map[string]string{
+			"argOne": "sample-arg",
+			"AUTHOR": userEmail,
+		},
 	}
 	context := &model.ExecutionContext{
 		UserEmail: userEmail,

diff --git a/internal/pkg/constant/constant.go b/internal/pkg/constant/constant.go
@@ -49,3 +49,4 @@ const AccessTokenHeaderKey = "Access-Token"
 const ClientVersionHeaderKey = "Client-Version"
 
 const WorkerEmail = "worker@proctor"
+const AuthorEmailKey = "AUTHOR"