Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secure_channel): fix data race in Receive() #232

Merged
merged 1 commit into from
Jul 10, 2019
Merged

fix(secure_channel): fix data race in Receive() #232

merged 1 commit into from
Jul 10, 2019

Conversation

alexbrdn
Copy link
Collaborator

@alexbrdn alexbrdn commented Jul 1, 2019

fixed by removing the offending line (see #231 (comment))

closes #231

@dwhutchison
Copy link
Collaborator

As mentioned in #231, this does break the server code which isn't complete yet so no big deal; the live client is more important so this can be merged until a proper fix is completed.

I'll play around with a few thoughts to fix this properly for #177

@magiconair magiconair merged commit 3a9584a into master Jul 10, 2019
@magiconair magiconair deleted the fix/sechan-data-race#231 branch July 10, 2019 21:10
@magiconair magiconair added this to the v0.1.2 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.2
Development

Successfully merging this pull request may close these issues.

Data Race in SecureChannel (yet another)
3 participants
@alexbrdn @dwhutchison @magiconair