Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(id-cmd): split up id files into multiple files #680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(id-cmd): split up id files into multiple files #680

wants to merge 1 commit into from

Conversation

sruehl
Copy link
Contributor

@sruehl sruehl commented Aug 23, 2023

This PR spilts up id_gen.go into multiple files

resolves #679

sruehl referenced this pull request in apache/plc4x Aug 28, 2023
@sruehl
fix(opcua): split up enums
03a9174
@sruehl
Copy link
Contributor Author

sruehl commented Aug 29, 2023

On note on this PR. The variables enum is still to big. In plc4x I solved it with this regex ^([A-Z][a-z]*)(.*),Variable$ -> $1$2,Variable$1 apache/plc4x@b2f3acb. I could extend this PR to split them even more up like I did in the plc4x commit.

@sruehl sruehl mentioned this pull request Aug 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

id_gen.go too large
1 participant
@sruehl