Margin resize #95
Merged
Margin resize #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhad01
force-pushed
the
margin_resize
branch
from
b3f707c
to
e140335
Compare
FittedSheetsPod/SheetSize.swift
Outdated
| @@ -14,6 +14,7 @@ public enum SheetSize: Equatable { | |||
| case fixed(CGFloat) | |||
| case fullscreen | |||
| case percent(Float) | |||
| case margin(CGFloat) | |||
There was a problem hiding this comment.
This should probably be .fullscreenWithTopMargin(CGFloat), to indicate what the base size is. .margin(CGFloat) doesn't clearly indicate what it will be a margin on.
gordontucker
requested changes
Aug 13, 2020
|
With having margin it will not be fullscreen anymore.
because of the fixed leading trailing and bottom just top lefts to have margin so in my opinion its ok but if you don’t like that how about .fixedWithMarginFromTop?
… On Aug 13, 2020, at 11:18 PM, Gordon Tucker ***@***.***> wrote:
@gordontucker commented on this pull request.
In FittedSheetsPod/SheetSize.swift <#95 (comment)>:
> @@ -14,6 +14,7 @@ public enum SheetSize: Equatable {
case fixed(CGFloat)
case fullscreen
case percent(Float)
+ case margin(CGFloat)
This should probably be .fullscreenWithTopMargin(CGFloat), to indicate what the base size is. .margin(CGFloat) doesn't clearly indicate what it will be a margin on.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#95 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFCZR6447FJ3U3MXJT7W2NDSAQYOZANCNFSM4P6U5TXQ>.
|
|
It isn't a fixed size, so that wouldn't work. How about just |
done |
gordontucker
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can define height by constant margin from top now.