Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] RuntimeDirectory was introduced in 211. Use of < 231 doesn't make sense #739

Closed
2 tasks done
elibroftw opened this issue Nov 20, 2023 · 1 comment
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@elibroftw
Copy link

What happened?

In https://nfpm.goreleaser.com/tips/#systemd, it's stated that RuntimeDirectory is used with systemd < 231, but this is not sourced.
From my notes and looking at the systemd changelog, I found that RuntimeDirectory= was introduced in version 211 that came out in 2014-03-12 https://github.com/systemd/systemd/blob/main/NEWS#L13926

How can we reproduce this?

N/A

nfpm version

N/A

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@elibroftw elibroftw added the bug Something isn't working label Nov 20, 2023
caarlos0 added a commit that referenced this issue Dec 6, 2023
@caarlos0
Copy link
Member

caarlos0 commented Dec 6, 2023

thanks, fixed

caarlos0 added a commit that referenced this issue Dec 7, 2023
* feat: allow to set a build date

defaults to $SOURCE_DATE_EPOCH

closes #744
closes #734

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: rename to mtime

* docs: fix systemd note

closes #739

* fix: improve arch packager

* fix: arch test

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: improve apk packager

* fix: improve deb special files

* fix: reuse keys func

* fix: deps

Signed-off-by: Carlos Alexandro Becker <[email protected]>

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants