Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle files owned by fs #760

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: properly handle files owned by fs #760

merged 1 commit into from
Jan 5, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 28, 2023

closes #738

I hardcoded all the directories owned by the filesystem package, I think it should be enough for now... we can make this configurable in the future if needed.

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 added the bug Something isn't working label Dec 28, 2023
@caarlos0 caarlos0 added this to the 2.36.0 milestone Dec 28, 2023
@caarlos0 caarlos0 self-assigned this Dec 28, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 28, 2023
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cfaeaa
Status: ✅  Deploy successful!
Preview URL: https://80720181.nfpm.pages.dev
Branch Preview URL: https://fs.nfpm.pages.dev

View logs

@caarlos0 caarlos0 requested a review from a team December 28, 2023 12:40
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c2fe69e) 75.20% compared to head (1cfaeaa) 75.15%.
Report is 1 commits behind head on main.

Files Patch % Lines
files/fs.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   75.20%   75.15%   -0.06%     
==========================================
  Files          12       13       +1     
  Lines        2468     2475       +7     
==========================================
+ Hits         1856     1860       +4     
- Misses        433      435       +2     
- Partials      179      180       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit beb0f73 into main Jan 5, 2024
39 of 42 checks passed
@caarlos0 caarlos0 deleted the fs branch January 5, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad rights on created subdirectories
1 participant