Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add s390x support #802

Merged
merged 1 commit into from
Mar 19, 2024
Merged

add s390x support #802

merged 1 commit into from
Mar 19, 2024

Conversation

lysliu
Copy link
Contributor

@lysliu lysliu commented Mar 19, 2024

Fix: #801

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2024
acceptance_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (29c8a21) to head (de0747e).

❗ Current head de0747e differs from pull request most recent head d9180c5. Consider uploading reports for the commit d9180c5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #802   +/-   ##
=======================================
  Coverage   72.23%   72.23%           
=======================================
  Files          20       20           
  Lines        2219     2219           
=======================================
  Hits         1603     1603           
  Misses        435      435           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yan Song Liu <[email protected]>
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2024
@caarlos0 caarlos0 merged commit ad01617 into goreleaser:main Mar 19, 2024
1 of 2 checks passed
@github-actions github-actions bot added this to the 2.36.0 milestone Mar 19, 2024
@Repana-Chowdappa
Copy link

Repana-Chowdappa commented Mar 19, 2024

@lysliu @caarlos0 Can we specify the arch value as "s390x" instead of s390? so that binary will come as nfpm_2.35.3_Linux_s390x.tar.gz

caarlos0 added a commit that referenced this pull request Mar 19, 2024
refs #802

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
Copy link
Member

done in 507ad79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s390x support
3 participants