Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Frame transparency doesn't work for the whole replacement frame #299

Closed
gorhill opened this issue May 24, 2014 · 2 comments
Closed

Frame transparency doesn't work for the whole replacement frame #299

gorhill opened this issue May 24, 2014 · 2 comments

Comments

@gorhill
Copy link
Owner

gorhill commented May 24, 2014

As reported by @ruimams in #298:

Well, in case Ken-g6 wasnt clear, this is not very effective: image

That's a video stream with a blocked ad over it.
Even if I set "Blocked frames color" to transparent, the box that says the domain of the blocked frame still appears.

EDIT: Ok, (I think) I now see what you meant. Anyways this is a feature request so it's your call. In my opinion it's a good idea to have that option (it could be off by default).

URL where the problem is highlighted:

Sure, www.ptcanal.com/tvi.php.

@gorhill gorhill changed the title Frame transparency doesn't work for the whole frame Frame transparency doesn't work for the whole replacement frame May 25, 2014
@gorhill
Copy link
Owner Author

gorhill commented May 25, 2014

Just to be clear, even when setting opacity to 0 in the CSS color, the label is still opaque.

Solution so far: to parse the CSS color to extract opacity and color component separately, and make the label transparent if opacity is exactly 0.

@gorhill
Copy link
Owner Author

gorhill commented May 25, 2014

That looks cool. It's code in the content script? (i.e. does that work if javascript is blocked?)

wondering if theres a possible ABP cosmetic filter that we can use to hide the iframe in the parent doc of a blocked sub_frame

ABP cosmetic filters are essentially anything which respect CSS3 selector syntax. I am not aware of any CSS selector which could be used to detect frames blocked by HTTPSB. Once I thought it would be easy to nail by having a CSS selector like iframe[src^="data:text/html,[first x characters of httpsb-generated base64 code], but the src attribute retains the original URL, not the redirected one. Of course that would have been too easy.

The way I see it so far, only after DOMContentLoaded, and the content script will have to send a laundry list of images and iframes so that the extension can mark whatever entry as blocked, and return the result, upon which the content script will hide each element marked as blocked.

In any case, my comment here is for #298. The opacity problem is a separate issue.

gorhill added a commit that referenced this issue May 26, 2014
@gorhill gorhill closed this as completed May 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant