Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate filter lists #1181

Closed
ghost opened this issue Jan 6, 2016 · 8 comments
Closed

Duplicate filter lists #1181

ghost opened this issue Jan 6, 2016 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 6, 2016

  1. If I add EasyList Germany from https://adblockplus.org/subscriptions uBO will add it in the box under "One URL per line" and ignore it. It would be better if uBO just activated the list in the settings.
  2. I'm able to add "EasyList Germany+EasyList" while both EasyList and EasyList Germany are already checked in uBO.
  3. I'm able to add EasyPrivacy and uBO will not ignore it but add it under "Custom".
@ghost
Copy link
Author

ghost commented Jan 16, 2016

On a somewhat similar note: You could rename Fanboy’s Annoyance List to Fanboy’s Annoyance List (includes Social Blocking List‎) so people don't unnecessarily download both. uBO ignores the duplicate filters but it puts some load on the servers.

@ghost
Copy link
Author

ghost commented Jan 26, 2016

uBO should also treat http://example.com/filterlist.txt as if it's the same as https://example.com/filterlist.txt. To add to that: If the user is subscribed to http://example.com/filterlist.txt and adds https://example.com/filterlist.txt uBO should simply replace the Non-SSL with the SSL version.

@bhabba
Copy link

bhabba commented Feb 9, 2016

Regarding filter lists that are subsets of other filter lists (currently only for example Fanboy's Social Blocking List which is a subset of Fanboy’s Annoyance List): I suggest using radio buttons for them if feasible so it's not possible to select both of them together in the first place. Of course some additional comment like what @IDKwhattoputhere suggested would still be helpful.

@ghost
Copy link
Author

ghost commented Feb 9, 2016

I think this also applies to Malware domains‎ and Malware domains (long-lived) like you can see here. The minimal difference of 5 filters could be a result of the mirror used for Malware domains (long-lived) not being up to date.
Maybe there can also be something done about Fanboy+Easylist-Merged Ultimate List‎ which includes Easylist, Easyprivacy, Fanboy’s Enhanced Tracking List‎ and Fanboy’s Annoyance List‎.

@TPS
Copy link

TPS commented Feb 28, 2016

Maybe a couple of sub-proposals here to help think this out: When 1 isan advanced user, bias filterlist processing so that:

  • httpslists are processed beforehttp1s
  • larger lists are processed before smaller 1s

then someway highlight unused (but ☑ed-&-downloaded) lists for further analysis, purging, & un☑ing.

@gorhill
Copy link
Owner

gorhill commented Feb 28, 2016

To be clear: the only thing I accept to possibly fix here is 1) and 3).

Repository owner locked and limited conversation to collaborators Feb 28, 2016
@gorhill
Copy link
Owner

gorhill commented Jan 21, 2017

I will revisit the meaning of the external filter lists area in the "3rd-party filters" pane: it will become a way to import external filter lists -- as opposed to currently being a way to declare external filter lists.

When one will click the Import button (which will replace the current Parse one), whatever (valid) filter lists in there will be imported, and the import text field will be reset to an empty text area (because it has been processed). Imported URLs which match those in the stock filter lists will cause the respective stock filter list to be selected.

To remove an imported filter list, there will be a X button aside the list to mark it for removal.

@gorhill
Copy link
Owner

gorhill commented Jan 23, 2017

Fixed with 9309df4.

As stated above, point 2 is wontfix because the list can't be reverse-mapped to a stock list in uBO.

@gorhill gorhill closed this as completed Jan 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants