Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[How to block] Action Panels on YouTube #1335

Closed
ThisIsTooHardStepToTake opened this issue Feb 3, 2016 · 8 comments
Closed

[How to block] Action Panels on YouTube #1335

ThisIsTooHardStepToTake opened this issue Feb 3, 2016 · 8 comments

Comments

@ThisIsTooHardStepToTake
Copy link

I tried to block Action Panels with ###watch-action-panels with no luck. I also have a YouTube Other Annoyances Filter list by Adblock and I think it's not working as it should. I know I should report this bug to them but I wanted to ask you first. Then I can link this thread after I've contacted you. I also checked out the uBO Logger but I'm not 100% sure if I saw anything there.

This is from the Adblock's list which should work but it's not working if I understand correctly.

! Removes sharing tab below videos
||youtube.com/share_ajax?action_get_share_box=1&video_id=$xmlhttprequest
youtube.com##.action-panel-trigger[role="button"][data-trigger-for="action-panel-share"]
youtube.com##.yt-uix-button[data-trigger-for="action-panel-share"]

untitled

I also found this thread on Adblock's forum.

Here's a example video for you.

@gorhill
Copy link
Owner

gorhill commented Feb 3, 2016

I have no problem creating a filter for #watch-action-panels with the element picker.

See if the filter is in My filters in the dashboard. If so, then find out why it is not applied: https://github.com/gorhill/uBlock/wiki/Element-picker#the-removed-element-reappears-when-you-reload-the-page.

@ThisIsTooHardStepToTake
Copy link
Author

It does appear there:

untitled

But somehow this rule is not working because YouTube will somehow inject the Action Panel again when you refresh the page.

@gorhill
Copy link
Owner

gorhill commented Feb 3, 2016

YouTube will somehow inject the Action Panel again when you refresh the page.

It works here. The panel is not removed by uBO, a display: none !important; style is applied to it. Since it works fine from here, the best explanation is that something is overriding the cosmetic filter on your side, be sure to rule out the reasons in the link I provided above.

@ThisIsTooHardStepToTake
Copy link
Author

I also tried to disable YouTube Other Annoyances filter list and only enabled the #watch-action-panels rule, it will hide the Action Panel yes but it will display the Action Panel like 2 seconds before hiding it.

EDIT:

This one rule will work much better when YouTube Other Annoyances rule is disabled.

@gorhill
Copy link
Owner

gorhill commented Feb 3, 2016

it will hide the Action Panel yes but it will display the Action Panel like 2 seconds before hiding it.

What is your browser? How many extensions do you have, and what are they? What is your CPU/memory?

youtube.com###watch-action-panels is a specific cosmetic filter, meaning it is injected before the DOM of the page is completely loaded, there should be no glitch typically.

@ThisIsTooHardStepToTake
Copy link
Author

Browser: Chrome Canary 50.0.2638.0 x64
uBO: 1.5.6 (Only extension I have)
CPU: Intel Core i7-4790K
RAM: 16GB DDR3 2133MHz

EDIT:

As soon as comments section is loaded it will hide the Action Panel.

@gorhill
Copy link
Owner

gorhill commented Feb 3, 2016

First:

I tried to block Action Panels with ###watch-action-panels with no luck.

Then, after I spent time trying to reproduce your issue:

it will hide the Action Panel yes but it will display the Action Panel like 2 seconds before hiding it.

What is the issue exactly?

@gorhill
Copy link
Owner

gorhill commented Feb 3, 2016

it will display the Action Panel like 2 seconds before hiding it.

I have a hard time believing this given your h/w profile. Make a video to support this -- specific cosmetic filters will typically never cause DOM elements to glitch.

By the way, any issue occurring with Canary is invalid until it is also reproduced on a stable release of Chrome/Chromium -- it is spelled out in CONTRIBUTING.

@gorhill gorhill closed this as completed Feb 3, 2016
gorhill pushed a commit that referenced this issue Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants