Problems using a dark Desktop Theme

[maycontainnuts]

Browser: FF38
uBlock: 0.9.7.0

Firefox uses GTK+ on Linux. Color-settings by used GTK-Theme will affect rendering of browser content too. Current setup for textarea in dyna-rules.css could result in an unusable editor window [http://i.imgur.com/qOIVHXi.png].

• Not setting (light) textarea/background-color will solve that problem, (dark) GTK+ background-color will be used.
• Problem should also be solved by adding a dark text-color instead.

[gorhill]

You have a link for that dark desktop theme?

[gorhill]

Ok I see, it's a OS theme, not a Firefox one.

[gorhill]

Here is the thing, I can't fix if I can't test the result of code change. I am running Linux Mint. What is the fastest way for me to test this -- just trying to save much time here.

[maycontainnuts]

U should be able to change the Desktop Theme by using a "Settings Manager" or "Control Center".

[gorhill]

Yes, went there but it looks like my Firefox is not using the desktop theme. Is there a special flag for this in Firefox?

[gorhill]

I will push a dev build, tell me if this fixes your issue.

[maycontainnuts]

Dev build won't fix the problem. Textarea in dynamic rules tab is still white on white in edit mode. Could you plz add "color: black;" to #diff textarea in /src/css/dyna-rules.css. It will solve that problem.

[gorhill]

Any other textareas which also need to be revisited?

[maycontainnuts]

As far as i can see the other textareas receive color settings from OS theme only [http://imgur.com/tsWb4HCl.png].

[ghost]

Just wanted to pitch in and say that the OP is perhaps using a GTK3 build of Firefox (Firefox still uses GTK2 by default in pretty much all distro's as the GTK3 port is still in progress). GNOME provides a dark variant of the Aidwata theme that can be toggled in the tweak tool, which is in a way a GTK3 theme, causing all GTK3 apps (i.e. most importantly GNOME's own apps) to become dark, this theme however does not apply to GTK2 (perhaps there are themes in Mint/Cinnamon however that do).

I'm not sure this is something you would want to fix right now; it all depends on your perspective, you could enforce background and foreground colors on all elements to enforce a consistent style everywhere (like many websites do) or you could leave it as it is now, where it defaults to the colors from the system. The latter may be preferred by users that wish to enforce their desktop styles, but more often than not it will result in a clash of styles (although that may be up to the user to decide).

In the case of the GNOME GTK3 dark theme, perhaps Mozilla will even disable the dark theme for the GTK3 build of Firefox or hide it behind a setting in time (it can be enabled or disabled by the application proper through a setting).