Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic filters containing pseudo-elements do not show results in manual/interactive selection mode #2515

Closed
SSoulaimane opened this issue Apr 4, 2017 · 3 comments

Comments

@SSoulaimane
Copy link

Tank you for implementing cosmetic filters with pseudo-elements in the last rc #2448.

However in the manual selection mode when a cosmetic filter with pseudo-elements is entered, no result is shown, it shows the number 0 at the corner bottom of the input box and the 'create' button is disabled.

But still the filter works when manually entered in the user filters tab in the settings.

@gorhill
Copy link
Owner

gorhill commented Apr 4, 2017

no result is shown, it shows the number 0 at the corner bottom of the input box

It's not possible to querySelectorAll pseudo-elements, so it's not possible for uBO to programmatically find them on the page.

@SSoulaimane
Copy link
Author

I see, then I suggest the element whom the pseudo-element relates to be the one shown in the match, then the preview should work as :style() does, and the create button should be enabled.

@gorhill
Copy link
Owner

gorhill commented Sep 2, 2019

Fixed with 8d136ec.

@gorhill gorhill closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants