Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Ability to open the logger into the browser's sidebar #2854

Closed
gorhill opened this issue Aug 9, 2017 · 9 comments
Closed

[Firefox] Ability to open the logger into the browser's sidebar #2854

gorhill opened this issue Aug 9, 2017 · 9 comments

Comments

@gorhill
Copy link
Owner

gorhill commented Aug 9, 2017

Firefox WebExtensions API supports the sidebarAction API, which purpose is to open "a pane that is displayed at the left-hand side of the browser window, next to the web page."

I want to investigate whether using the sidebar API to host uBO's logger is practical. I can confirm it is feasible, by simply adding the following entry to uBO's manifest file:

"sidebar_action": {
   "default_icon": {
      "19":"img/browsericons/icon19.png",
      "38":"img/browsericons/icon38.png"
   },
   "default_title" : "uBlock Origin logger",
   "default_panel": "logger-ui.html"
},

Result:

a

Issues to investigate/solve:

  • The drop-down list at the top of the logger does not work, for unknown reasons.
  • There can be only one logger document opened at any given time, so these approaches must be mutually exclusive:
    • Logger in a separate tab
    • Logger as a popup window
    • Logger in the sidebar
      • Complication: there can be only one logger, so need to deal with the case of many windows with sidebar opened.
  • Verify that this also work on Opera, which also supports the sidebar API
    • Using the browser's sidebar is practical only if the maximum width allowed is sufficient
@heubergen
Copy link

I'm not intend to disturb you but the drop-down seems to work for me with Firefox Nightly. I can select a site and the logger also only shows the requests from the selected site.
screen shot 2017-08-09 at 9 56 07 pm

@gorhill
Copy link
Owner Author

gorhill commented Aug 9, 2017

Looks like you are on MacOS? Could be a Linux-specific issue.

@heubergen
Copy link

Yes, I'm using MacOS. Maybe someone with Windows OS can confirm the issue?

@luxoflux
Copy link

Just some ideas:

  • Left-click on the logger icon would behave as normal
  • Right-click opens in the sidebar
  • Middle-click opens in a new window

And the tooltip could list these options.

@gorhill
Copy link
Owner Author

gorhill commented Sep 1, 2017

Drop list issue in sidebar: https://bugzilla.mozilla.org/show_bug.cgi?id=1190679#c11.

@sn260591
Copy link

How about devtools panel? This can also be implemented in Chrome.

@elypter
Copy link

elypter commented Oct 30, 2017

it would be cool to have this for vivaldi too.

@gorhill
Copy link
Owner Author

gorhill commented Nov 12, 2017

How about devtools panel?

uBO's logger is unified. A dev tool panel is meant to provide tools for the current page only. For instance, had the logger not been unified and implemented as a dev panel, it would be next to impossible to witness Instart Logic at work -- uBO's logger is out of reach of such ploy used by Instart Logic.

@gorhill
Copy link
Owner Author

gorhill commented Jan 8, 2018

This will need to be fixed for Opera too, it supports side bars.

@gorhill gorhill closed this as completed Jan 11, 2018
@gorhill gorhill changed the title [Firefox] Investigate having the logger into the browser's sidebar [Firefox] Ability to open the logger into the browser's sidebar Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants