Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you reopen 2029? #2874

Closed
corysimmons opened this issue Aug 15, 2017 · 6 comments
Closed

Can you reopen 2029? #2874

corysimmons opened this issue Aug 15, 2017 · 6 comments
Labels

Comments

@corysimmons
Copy link

#2029

The conversation was productive except for this single comment.

The problem also affects API developers.

image

image

Really frustrating having to dive into chrome://extensions to disable uBlock every time I'm doing API dev.

@gorhill
Copy link
Owner

gorhill commented Aug 15, 2017

What is there more to say? The issue is still opened, which means I do intend to do something.

@corysimmons
Copy link
Author

Okay, I didn't realize you intended to fix it. Thank you.

@gorhill
Copy link
Owner

gorhill commented Aug 15, 2017

By the way, what is the type of document which caused the error message in your pic?

@corysimmons
Copy link
Author

text/plain. You can hit it here if you want: https://shielded-hamlet-97718.herokuapp.com/v1/trucks

@gorhill
Copy link
Owner

gorhill commented Aug 15, 2017

One idea is to ask the browser devs to add a content type filter to content_scripts declaration so that the browser injects the scripts if and only if there is a document type match. This would be a better solution since the browser would completely skip injecting the scripts, removing the need to test/abort content script side after they are injected.

@corysimmons
Copy link
Author

I don't imagine they'd do it, especially not without months of convincing them, but I'm sure you'd have more clout than me in that sales pitch.

What was the problem with the IIFE anyway? I've never heard of an IIFE being a perf hit.

gorhill added a commit that referenced this issue Oct 16, 2023
TimTheBig added a commit to TimTheBig/uBlock-plus-plus that referenced this issue Oct 16, 2023
TimTheBig added a commit to TimTheBig/uBlock-plus-plus that referenced this issue Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants