-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middle clicking on a link triggers popup rule, but only since updating to webext-hybrid. #2919
Comments
It has been a long time I played with that code, but I believe uBO was disregarding that the link was clicked by the user because it was not possible on Chromium to detect whether a click was the result of the user clicking, or whether it was programmatically triggered by nasty javascript code. Looking at current MDN documentation, it says that the |
Sounds good! Do you have some automated test cases or something to help you test for feature parity between the legacy version of uBO and the WebExt ? Since that one seems to be a port from the Chrome version, there could be several such tiny things, some of which unnoticeable by users. And manual testing sounds like a daunting task... |
The issue still occurs (on a fresh browser profile + uBO): FF 55.0.3 32bit + uBO v1.14.9b0 |
See If you middle click the first link the tab opens and then closes due to this filter: As you arrive on that page through isTrusted action it shouldn't be considered as |
When I click the link, a new tab opens with Google Search page. Without an actual repro case, I can't investigate. |
What link exactly? I tried the one you posted above, "first link", and can't reproduce any closed popup: But anyways, from your screenshot, the popup was properly closed, because the URL of the popup changed from the one clicked by the user, which is what the fix is here. The 3rd-partyness is properly evaluated in this case, the 1st party is still the URL of the tab from where the popup was opened. |
Weird ..: if I middle click How could be |
The party-ness is always opener tab vs opened tab, regardless of redirection (however this redirection happens). The opener tab in the current case is always If I understand the case here, the reporter on EasyList forum argues that the redirection to same domain as the trusted URL's one should not trigger popup filter. |
Describe the issue
When middle clicking on a link that directs to a site blocked from opening pop ups by a filter, this link does not open. It is treated like a pop up instead of a new tab, and this only happens since 1.13.10.
One or more specific URLs where the issue occurs
anilinkz.to/anime-list
Steps for anyone to reproduce the issue
||anilinkz.$first-party,popup
anilinkz.to/anime-list
Your settings
The text was updated successfully, but these errors were encountered: