$popup does not work #1785
Comments
You probably meant The popup is not closed because the destination is not blocked as a popup, you need: Your popup filter |
|
Yes, of course I meant The fact is, when using Adblock Plus, I observe different behavior and the rule |
|
The current behavior was not decided considering ABP, it was chosen according to the number of false positives being reported, and was fine tuned with gorhill/uBlock#2919. A common issue with popup filters was the regular instances of false positives. The chosen behavior is that if the user click a link and a new tab open as a result which matches exactly the clicked link, the navigation is deemed legitimate and won't be filtered. There is no surprise in such case, and this took care of a lot of false positives. However, I realize that in the current case, the legitimate navigation redirects immediately to a URL which is unrelated to the original link, this kind of work against the link being legitimate. I need to think about what could be done in such case without bringing back instances of false positives like in the past. |
|
Trying to further fine tune the current heuristic does not work, it's just going to create more quirks. What works well though is leveraging the In such case, uBO could bypass the assumption that the link clicked is trusted because it caused a navigation to a new tab which URL matches that of the clicked link. |
|
Oh, this will require creating (for uBO) a new section of pop-up rules with the "important" option in each filter, since Adblock Plus does not understand this option. |
Does it just ignore the |
|
I created a separate version RU AdList for uBO. It differs in additional files that contain scriptlet-rules and rules for embedding styles. This is where the rules with the "important" option meet: This is not the case in the regular version: It will be difficult to add the "important" option for pop-up rules to all filters, including EasyList, in order to ensure their performance in uBO. The fact is that Adblock Plus does not know how to ignore unknown rules. Instead, it completely disables all rules of the type that are similar to the detected unknown rule on the domain. For example, adding rule |
You do not have to add it to all I can't go back on the current heuristic, there were regular reports of unduly closed tab after clicking legitimate links, and after years of using the current heuristic, this was a good improvement as witnessed by the (lack of) issues filed regarding false positive with |
|
We never know in advance exactly where we need to add "important". And the very principle of the need for such an addition makes debugging difficult, since you must always keep in mind that the behavior ABP and uBO is different. Ultimately, this leads to filters fragmentation. The current heuristic to allow ad link click only because the click is direct seems dubious to me. I carefully studied gorhill/uBlock#2919 and came to the conclusion that the described false positives needed to be corrected in the filters. For example: Etc |
The issue I linked to has also related issues linked to it, for example uBlockOrigin/uAssets#720, and in the comments other contributors have a differing opinion. I agreed with them, hence why the current heuristic. This was not only false positives with filters, but also false positive with the no-popups switch. Going back on that would be a regression in uBO. My proposed solution is to leverage |
|
As far as I can see, cases of false positives are of venerable age and belong to the period when the authors of EasyList and regional filters did not practice debugging rules in uBO. Now the situation has changed and this is what most filter authors do. Of course, you can do as you see fit, but the current heuristic changes the behavior of uBO compared to Adblock Plus and this forces the authors of all filters to always keep this in mind and perform separate checks that take this feature into account. |
|
It's difficult for me to make changes to the current behavior without seeing actual, real filter issue cases to convince me that the actual behavior must be changed -- the one you provide is artificial, it's not going to happen in the real world. |
|
Okay, do as you see fit. If real cases appear, it will be possible to return to this later. |
|
Is a popup filter still needed when cosmetic filter already have done the job? |
|
There is no need. But the current heuristic will disable pop-up blocking in cases where the advertising link is explicitly specified. For example, when branding the background. |
|
Also transparent link to trick user is common, but they should be addressed first by either cosmetic filter or scriptlet, shouldn't they? |
|
Yes, exactly. |
|
We usually fix popups in uBO with |
You don't need to do anything for the case provided here, you have to disable a cosmetic filter and click on an ad for it to happen -- something nobody is going to do. |
If I have to make an ad, which is hidden already, reappear and then click on it just to prove a point, seems not worth the time. |
|
I personally feel the difference btwn ABP & uBO here would hardly be a matter at least in terms of false negative. OTOH the ABP's way of $popup can really be a problem, a worse case of the click-through issue where average user has no chance to choose. Hmm, I certainly saw such a case - popup (kinda) false positive only on AG - actually at AG, can't remember soon. |
|
Maybe AdguardTeam/AdguardFilters#90055 Already fixed by EL and the link no more work but IIRC uBO didn't suffer at the time. |
|
As for the differences in behaviour with |
|
Yes, that would be the perfect solution. |
|
Hello. I have a similar issue on a website. It always opens a new window with a specific address. It does it no matter where I click, it does it even by reloading a page................ This popup: http://aniwatcher.com/search?q=ready And knowing the link, I created custom filters for it. Filters like: And the thing still opens this popup. And don't get me started with this "about:blank"............... Are there any more special commands to block these stupid popups? :( I keep uBlock on default settings, using the built-in filters. And there's no filter that interferes with mine. So does anyone have more ideas or advices in how to force block it? Because if that's it, then it has to be a bug, right? :( |
|
@LucianAndries I don't get any popup. Probably better to report with built-in report tool with all the details. |
Prerequisites
I tried to reproduce the issue when...
Description
$popup does not work
A specific URL where the issue occurs
https://trashbox.ru/link/2021-10-26-rawdrawSteps to Reproduce
trashbox.ru#@#a[href*="://trashbox.ru/r.php?"]https://trashbox.ru/link/2021-10-26-rawdrawExpected behavior
The popup should be blocked by the rule
||trashbox.ru/r.php?$popup, preventing the click on the advertising link.Actual behavior
There is a transition to the advertising link.
uBlock Origin version
uBlock Origin development build 1.38.7b9 (default + RUS: RU AdList)
Browser name and version
Google Chrome 95.0.4638.54
Operating System and version
Windows 7
The text was updated successfully, but these errors were encountered: