Add trusted origins feature #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 15, 2019
houndci-bot
reviewed
Jul 15, 2019
Closed
Instead of accepting []*url.URL, which can cause weird problems, now TrustedOrigins accept []string, which is the list of hosts accepted by the middleware...So the schema doesn't matter anymore and it's more friendly to use.
elithrar
suggested changes
Jul 15, 2019
houndci-bot
reviewed
Jul 15, 2019
|
Fixed. Thanks for the feedback. :) What do you think? |
|
Hey. Sorry for bothering but...do you have any additional feedback, @elithrar? :) Thanks. |
|
Nothing yet! I’m traveling until Friday & won’t have time for a proper
review until the weekend.
…On Wed, Jul 17, 2019 at 11:59 AM Fernando Jorge Mota < ***@***.***> wrote:
Hey.
Sorry for bothering but...do you have any additional feedback, @elithrar
<https://github.com/elithrar>? :)
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117?email_source=notifications&email_token=AAAEQ4HARJQO3PRI6KANQ7DP75FVBA5CNFSM4IDTWDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2FC4GY#issuecomment-512372251>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEQ4BERFSXDNNISIDV6DTP75FVBANCNFSM4IDTWDJQ>
.
|
|
Oh. Ok! I'll wait and continue to using my fork with this patch on my project, meanwhile. Have a nice trip. :) |
elithrar
approved these changes
Jul 20, 2019
|
Thanks for bearing with me & resolving the outstanding comments - merged! |
|
Nice, thank you for accepting the PR! Good luck with the project and keep the nice work. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116
I added tests and I accept feedbacks on the API.
I throught about accepting a.[]stringon the added option but we would need to return an error in the case of a URL being invalid, for exampleEDIT: Now the API is more Django-like, accepting
[]stringas a list of trusted hosts to check.