-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SameSite option #123
SameSite option #123
Conversation
Thank you! Will review this weekend.
…On Thu, Sep 26, 2019 at 9:04 PM Tom ***@***.***> wrote:
Fixes #121 <#121>
*Summary of Changes*
1. Add SameSite Modes to mirror http.SameSite values
2. Add SameSite to options
3. Split store into pre and post 1.11 versions to maintain backwards
compatibility
4. Option test for SameSite added
------------------------------
You can view, comment on, or merge this pull request online at:
#123
Commit Summary
- Add SameSite with build constraied
- Update options test
File Changes
- *M* csrf.go <https://github.com/gorilla/csrf/pull/123/files#diff-0>
(18)
- *M* options.go
<https://github.com/gorilla/csrf/pull/123/files#diff-1> (15)
- *M* options_test.go
<https://github.com/gorilla/csrf/pull/123/files#diff-2> (5)
- *M* store.go <https://github.com/gorilla/csrf/pull/123/files#diff-3>
(4)
- *A* store_deprecated.go
<https://github.com/gorilla/csrf/pull/123/files#diff-4> (86)
- *M* store_test.go
<https://github.com/gorilla/csrf/pull/123/files#diff-5> (4)
Patch Links:
- https://github.com/gorilla/csrf/pull/123.patch
- https://github.com/gorilla/csrf/pull/123.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#123?email_source=notifications&email_token=AAAEQ4GZFUVMZT3VHHZGGF3QLWA25A5CNFSM4I3BRBE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOBRACA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEQ4HX4CB4J4TGOL32JDDQLWA25ANCNFSM4I3BRBEQ>
.
|
My pleasure, looking forward to having the option. I'm out this weekend but can make any updates Sunday/Monday as needed |
@elithrar circling back to see if you have some time to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments:
• make the SameSite use-case clear to readers;
• Add a line to the README describing that it’s supported (and why it’s useful!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for this!
Fixes #121
Summary of Changes