Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] isPermaLink="false" for guid field #78

Closed
bayraktugrul opened this issue Jan 3, 2020 · 1 comment · Fixed by #107
Closed

[feature] isPermaLink="false" for guid field #78

bayraktugrul opened this issue Jan 3, 2020 · 1 comment · Fixed by #107
Labels
enhancement stale

Comments

@bayraktugrul
Copy link

By default, the guid element specifies a permanent link for an item, the value must be a full URL. If you are using the guid element simply as a unique identifier (and not a link to the item), then the value can be whatever you want, but you must include the attribute isPermaLink="false" in the guid tag. Could you add this feature?
…

Expected behavior
<guid isPermaLink="false">article 54 at example.com</guid>

Actual behavior
<guid>http://www.example.com/archives/000054.html</guid>
@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.

@stale stale bot added the stale label Mar 3, 2020
@stale stale bot closed this as completed Mar 10, 2020
@beaucollins beaucollins mentioned this issue Jan 8, 2024
Closed
@yardenshoham yardenshoham mentioned this issue Jan 10, 2024
Merged
12 tasks
@yardenshoham yardenshoham mentioned this issue Jan 19, 2024
Merged
lunny pushed a commit to go-gitea/gitea that referenced this issue Jan 20, 2024
@yardenshoham
Set the isPermaLink attribute to false in the guid sub-element (#…
5574968 
…28860)

Our `guid` is not a valid URL so according to the RSS spec the
`isPermaLink` attribute needs to be set to `false`.

Example:
```diff
<item>
  <title>yardenshoham opened issue &lt;a href=&#34;https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2&#34;&gt;yardenshoham/test#2&lt;/a&gt;</title>
  <link>https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</link>
  <description>2#hey</description>
  <content:encoded><![CDATA[2#hey]]></content:encoded>
  <author>yardenshoham</author>
- <guid>355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
+ <guid isPermaLink="false">355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
  <pubDate>Tue, 16 Jan 2024 18:54:36 +0000</pubDate>
</item>
```

References:
-
https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
- Fixes #28734
- gorilla/feeds#78
- #21550
- gorilla/feeds#107

Signed-off-by: Yarden Shoham <[email protected]>
yardenshoham added a commit to yardenshoham/gitea that referenced this issue Jan 20, 2024
@yardenshoham
Set the isPermaLink attribute to false in the guid sub-element (g…
0f20b83 
…o-gitea#28860)

Our `guid` is not a valid URL so according to the RSS spec the
`isPermaLink` attribute needs to be set to `false`.

Example:
```diff
<item>
  <title>yardenshoham opened issue &lt;a href=&#34;https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2&#34;&gt;yardenshoham/test#2&lt;/a&gt;</title>
  <link>https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</link>
  <description>2#hey</description>
  <content:encoded><![CDATA[2#hey]]></content:encoded>
  <author>yardenshoham</author>
- <guid>355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
+ <guid isPermaLink="false">355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
  <pubDate>Tue, 16 Jan 2024 18:54:36 +0000</pubDate>
</item>
```

References:
-
https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
- Fixes go-gitea#28734
- gorilla/feeds#78
- go-gitea#21550
- gorilla/feeds#107

Signed-off-by: Yarden Shoham <[email protected]>
@yardenshoham yardenshoham mentioned this issue Jan 20, 2024
Closed
henrygoodman pushed a commit to henrygoodman/gitea that referenced this issue Jan 31, 2024
@yardenshoham @henrygoodman
Set the isPermaLink attribute to false in the guid sub-element (g…
9d9a8e6 
…o-gitea#28860)

Our `guid` is not a valid URL so according to the RSS spec the
`isPermaLink` attribute needs to be set to `false`.

Example:
```diff
<item>
  <title>yardenshoham opened issue &lt;a href=&go-gitea#34;https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2&#34;&gt;yardenshoham/test#2&lt;/a&gt;</title>
  <link>https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</link>
  <description>2#hey</description>
  <content:encoded><![CDATA[2#hey]]></content:encoded>
  <author>yardenshoham</author>
- <guid>355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
+ <guid isPermaLink="false">355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
  <pubDate>Tue, 16 Jan 2024 18:54:36 +0000</pubDate>
</item>
```

References:
-
https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
- Fixes go-gitea#28734
- gorilla/feeds#78
- go-gitea#21550
- gorilla/feeds#107

Signed-off-by: Yarden Shoham <[email protected]>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@yardenshoham @silverwind
Set the isPermaLink attribute to false in the guid sub-element (g…
0091d15 
…o-gitea#28860)

Our `guid` is not a valid URL so according to the RSS spec the
`isPermaLink` attribute needs to be set to `false`.

Example:
```diff
<item>
  <title>yardenshoham opened issue &lt;a href=&go-gitea#34;https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2&#34;&gt;yardenshoham/test#2&lt;/a&gt;</title>
  <link>https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</link>
  <description>2#hey</description>
  <content:encoded><![CDATA[2#hey]]></content:encoded>
  <author>yardenshoham</author>
- <guid>355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
+ <guid isPermaLink="false">355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
  <pubDate>Tue, 16 Jan 2024 18:54:36 +0000</pubDate>
</item>
```

References:
-
https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
- Fixes go-gitea#28734
- gorilla/feeds#78
- go-gitea#21550
- gorilla/feeds#107

Signed-off-by: Yarden Shoham <[email protected]>
jaitaiwan pushed a commit that referenced this issue Jun 17, 2024
@yardenshoham
Add the isPermaLink attribute to guid in RSS (#107)
eb2fb30 
Adds the optional attribute from the `guid` RSS spec:
https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt

This is a breaking change to the `RssItem` struct as `Guid` is now a
struct, not a string.

- Related Issue go-gitea/gitea#28734
- Closes #78
- Closes #109 

Signed-off-by: Yarden Shoham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the isPermaLink attribute to guid in RSS yardenshoham/feeds
2 participants
@bayraktugrul and others