Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed golint warnings #526

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Fixed golint warnings #526

merged 1 commit into from
Nov 21, 2019

Conversation

kveselkov
Copy link
Contributor

Fixed:

  1. mux.go:366:5: error var SkipRouter should have name of the form ErrFoo
  2. regexp.go:184:9: if block ends with a return statement, so drop this else and outdent its block

elithrar
elithrar suggested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t accept changes that would break the public API.

mux.go Outdated
// router that walk is about to descend down to should be skipped.
var SkipRouter = errors.New("skip this router")
var ErrSkipRouter = errors.New("skip this router")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. That golint complains is unfortunate, but this predates golint.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@elithrar elithrar self-assigned this Nov 21, 2019
@elithrar elithrar merged commit 49c0148 into gorilla:master Nov 21, 2019
@elithrar
Copy link
Contributor

Thanks!

@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fharding1 fharding1 fharding1 approved these changes

@elithrar elithrar elithrar approved these changes

Assignees

@elithrar elithrar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kveselkov @elithrar @fharding1