check error before GotConn for trace

Signed-off-by: Ye Sijun <[email protected]>
gorilla · Jul 12, 2022 · af47554 · af47554
1 parent bc7ce89
commit af47554
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/client.go b/client.go
@@ -319,14 +319,14 @@ func (d *Dialer) DialContext(ctx context.Context, urlStr string, requestHeader h
 	}
 
 	netConn, err := netDial("tcp", hostPort)
+	if err != nil {
+		return nil, nil, err
+	}
 	if trace != nil && trace.GotConn != nil {
 		trace.GotConn(httptrace.GotConnInfo{
 			Conn: netConn,
 		})
 	}
-	if err != nil {
-		return nil, nil, err
-	}
 
 	defer func() {
 		if netConn != nil {