add support for https proxy #548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this would be really great 🙏 |
elithrar
suggested changes
Mar 19, 2020
| type tlsDialer struct { | ||
| } | ||
|
|
||
| func (t *tlsDialer) Dial(network, addr string) (c net.Conn, err error) { |
There was a problem hiding this comment.
Public methods need documentation as to their use-case.
costanic
added a commit
to PelionIoT/edge-proxy
that referenced
this pull request
Jan 13, 2021
costanic
added a commit
to costanic/websocket
that referenced
this pull request
Jan 13, 2021
costanic
added a commit
to PelionIoT/edge-proxy
that referenced
this pull request
Jan 14, 2021
the fork has support for https proxies:
gorilla/websocket#548
we should switch back to the gorilla/websocket project when
this PR is merged and a new release tagged.
costanic
added a commit
to PelionIoT/edge-proxy
that referenced
this pull request
Jan 14, 2021
the fork has support for https proxies:
gorilla/websocket#548
we should switch back to the gorilla/websocket project when
this PR is merged and a new release tagged.
costanic
added a commit
to PelionIoT/edge-proxy
that referenced
this pull request
Jan 20, 2021
the fork has support for https proxies:
gorilla/websocket#548
we should switch back to the gorilla/websocket project when
this PR is merged and a new release tagged.
|
whyy, I need this :( |
JanneKiiskila
pushed a commit
to PelionIoT/websocket
that referenced
this pull request
May 28, 2024
Cherry-picking the proxy support from v1.4.2-1 tag. gorilla#548 (cherry picked from commit 9b1460a) Signed-off-by: Janne Kiiskilä <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using websockets behind an https proxy. You can test by setting the env variable HTTP_PROXY to a proxy server and attempting to use the websocket library as normal.