Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to update the tab associated to a node ? #49

Open
Sangrene opened this issue May 23, 2024 · 4 comments · May be fixed by #56
Open

Is it possible to update the tab associated to a node ? #49

Sangrene opened this issue May 23, 2024 · 4 comments · May be fixed by #56
Labels
enhancement New feature or request

Comments

@Sangrene
Copy link

Hi, great lib :)

I created a custom node, which needs configuration, pretty close to the Function node.
I was searching how to implement a custom Tab when I found these lines :
https://github.com/gorules/jdm-editor/blob/a3ea6e6a9a09a57a75a4a786b2cdd909e8c07098/packages/jdm-editor/src/components/decision-graph/dg-wrapper.tsx#L71C1-L75C15

So it seems like it is not possible.
Do you plan to implement custom Tabs in the DecisionGraph props ? If not, would you accept a PR implementing this feature ?
@Sangrene Sangrene linked a pull request May 24, 2024 that will close this issue
Open
@ivanmiletic
Copy link
Contributor

At the moment it is not possible but this is something that we can take a look at

@ivanmiletic ivanmiletic added the enhancement New feature or request label Jun 6, 2024
@Sangrene
Copy link
Author

Sangrene commented Jun 6, 2024

Yep I know, see the PR I created implementing this feature :)

@ivanmiletic
Copy link
Contributor

Looks good, we will check it

@stefan-gorules
Copy link
Contributor

Hi @Sangrene, just an update here and apology for not having time to focus on this earlier. We are currently working on diff functionality (allowing for comparison between 2 graphs). With it, we will also ship ability to declare a custom tab for the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow custom tabs Sangrene/jdm-editor
3 participants
@Sangrene @ivanmiletic @stefan-gorules