Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom tabs #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sangrene
Copy link

This PR adds support for custom tabs following this type:

export type Tab = { type: string; tab: (p: CommonTabProps) => ReactNode };

type being the Node type that should be updated.

I also added a story for this.

Should fix #49 .

@Sangrene Sangrene changed the title Feat/allow custom tabs feat: allow custom tabs May 24, 2024
@stefan-gorules
Copy link
Contributor

Code looks good, we'll just have to run a few tests on our side and you can expect this to be approved early next week.

Appreciate the contribution!

@Sangrene
Copy link
Author

Any news on this @ivanmiletic @stefan-gorules ?
Thanks

@ivanmiletic
Copy link
Contributor

Hi @Sangrene was taking a look at this, as we are moving to a direction of a node specification we would like to have tabs part of a node specification.

Example you define node and you define its own tab and it will allow us to open tab for that specific node.

As we are doing a few big features in parallel, we will have time to tackle this end of next week.

@Sangrene
Copy link
Author

I totally agree with that architecture change, I wanted to do it but felt like following the current architecture was more important :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to update the tab associated to a node ?
3 participants