Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darwin/arm64 support #834

Closed
JonZeolla opened this issue Sep 1, 2023 · 4 comments · Fixed by #835
Closed

Add darwin/arm64 support #834

JonZeolla opened this issue Sep 1, 2023 · 4 comments · Fixed by #835

Comments

@JonZeolla
Copy link

Describe the feature:
I would like to run goss and the dgoss wrapper from on my M1 Max MBP.

Describe the solution you'd like
Please support and distribute binaries compiled for darwin/arm64 so it can be used on Apple Silicon

Describe alternatives you've considered
I have looked at some of the existing issues and PRs, and attempted to run the linux/arm64 binary unsuccessfully, receiving the following error:

$ goss --version
zsh: exec format error: goss
@aelsabbahy
Copy link
Member

aelsabbahy commented Sep 1, 2023

Hello, are you running goss on MacOS to test your MBP, or are you running goss in a docker container running on MacOS to test the container?

If the latter, let me know if my comment here helps.

If the former, then yeah.. looks like a new binary needs to be added to the build/release process.

@JonZeolla
Copy link
Author

👋

Right - I’m looking for support of the former to test new laptop setups. My docker / dgoss usage is not a problem (thank you for the tooling btw this is great!)

@JonZeolla
Copy link
Author

Wow, fast turnaround time @aelsabbahy thank you

@aelsabbahy
Copy link
Member

No problem, was a low hanging fruit.

Feel free to file any bugs/feature requests for the Mac version and/or documentation.

FYI: Parity docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants