Use GOSS_FILE environment variable for dgoss #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcozier
reviewed
Jun 6, 2019
|
Yes, sorry 🤦♂️ |
fbartels
added a commit
to fbartels/goss
that referenced
this pull request
Aug 24, 2019
Signed-off-by: Felix Bartels <[email protected]>
fbartels
added a commit
to fbartels/goss
that referenced
this pull request
Nov 11, 2019
Signed-off-by: Felix Bartels <[email protected]>
fbartels
added a commit
to fbartels/goss
that referenced
this pull request
Nov 25, 2019
Signed-off-by: Felix Bartels <[email protected]>
fbartels
added a commit
to fbartels/goss
that referenced
this pull request
Nov 25, 2019
add option to enable debug output of dcgoss * do not delete tmp dir when running in debug Runtime improvements: raise default timeout also stop container started with docker-compose run move goss sleep to the beginning of the test run do not delete container after run, rather stop it print logs on error print total runtime of test at the end implement goss_file option from goss-org#454 always copy goss.yaml as well only copy goss_file when it exists do not run edit mode, when goss_file is set better handling for goss_file delete testing object after run use install instead of cp * this allows to specify permissions of the resulting file. otherwise it may not be writeable in the target Improve documentation: * document debug option * add example compose file * consistently use the db container as the example * add example for goss files path
fbartels
added a commit
to fbartels/goss
that referenced
this pull request
Nov 30, 2019
add option to enable debug output of dcgoss * do not delete tmp dir when running in debug Runtime improvements: raise default timeout also stop container started with docker-compose run move goss sleep to the beginning of the test run do not delete container after run, rather stop it print logs on error print total runtime of test at the end implement goss_file option from goss-org#454 always copy goss.yaml as well only copy goss_file when it exists do not run edit mode, when goss_file is set better handling for goss_file delete testing object after run use install instead of cp * this allows to specify permissions of the resulting file. otherwise it may not be writeable in the target Improve documentation: * document debug option * add example compose file * consistently use the db container as the example * add example for goss files path
aelsabbahy
pushed a commit
that referenced
this pull request
Dec 6, 2019
* Debugging improvements: add option to enable debug output of dcgoss * do not delete tmp dir when running in debug Runtime improvements: raise default timeout also stop container started with docker-compose run move goss sleep to the beginning of the test run do not delete container after run, rather stop it print logs on error print total runtime of test at the end implement goss_file option from #454 always copy goss.yaml as well only copy goss_file when it exists do not run edit mode, when goss_file is set better handling for goss_file delete testing object after run use install instead of cp * this allows to specify permissions of the resulting file. otherwise it may not be writeable in the target Improve documentation: * document debug option * add example compose file * consistently use the db container as the example * add example for goss files path * fix readme clean todos Signed-off-by: Felix Bartels <[email protected]>
|
Sorry for the late response on this. Looks good to me, can you resolve the conflict and add the new variable to the dgoss README? Aside from that, good to go. |
|
I hope it's ready to merge. Let me know any change that I should do. Thanks. |
|
LGTM! Thank you for your contribution. |
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Debugging improvements: add option to enable debug output of dcgoss * do not delete tmp dir when running in debug Runtime improvements: raise default timeout also stop container started with docker-compose run move goss sleep to the beginning of the test run do not delete container after run, rather stop it print logs on error print total runtime of test at the end implement goss_file option from goss-org#454 always copy goss.yaml as well only copy goss_file when it exists do not run edit mode, when goss_file is set better handling for goss_file delete testing object after run use install instead of cp * this allows to specify permissions of the resulting file. otherwise it may not be writeable in the target Improve documentation: * document debug option * add example compose file * consistently use the db container as the example * add example for goss files path * fix readme clean todos Signed-off-by: Felix Bartels <[email protected]>
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Use GOSS_FILE environment variable for dgoss * Fix a typo in environment variable * Update and documentation on README.md * Resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows use
GOSS_FILEenvironment variable fordgoss. If not defined then usegoss.yamlas it's now.Only set the filename to copy into the container. In the container the name is
goss.yamlto avoid more changes in the script.