Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uid/gid check in file module #883

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

smutel
Copy link
Contributor

@smutel smutel commented Mar 13, 2024

Checklist
  • [ X] make test-all (UNIX) passes. CI will also test this
  • [ X] unit and/or integration tests are included (if applicable)
  • [ X] documentation is changed or added (if applicable)

Description of change

Add UID/GID check for file module
For my purpose I need to check the uid/gid instead of the owner/group

@smutel smutel force-pushed the AbleToUseUidGid branch 4 times, most recently from f757b0c to 359fd98 Compare March 13, 2024 11:05
@smutel smutel marked this pull request as ready for review March 13, 2024 13:11
@smutel smutel requested a review from aelsabbahy as a code owner March 13, 2024 13:11
Copy link
Member

@aelsabbahy aelsabbahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool addition, thank you for taking the time to implement this!

@aelsabbahy aelsabbahy merged commit be023fa into goss-org:master Mar 17, 2024
1 check passed
@smutel
Copy link
Contributor Author

smutel commented Mar 18, 2024

Thank you to have merged my PR @aelsabbahy.
Do you have plan a new release soon ?

@aelsabbahy
Copy link
Member

aelsabbahy commented Mar 21, 2024

Tried to cut a release today, but running into travis-ci issues with their deploy plugin.

** Updating RubyGems to the latest compatible version for security reasons. **
** If you need an older version, you can downgrade with 'gem update --system OLD_VERSION'. **
dpl.1
Installing deploy dependencies
ERROR:  Error installing dpl-releases:
	multipart-post requires Ruby version >= 2.5.0.
Successfully installed public_suffix-3.0.3
Successfully installed mime-types-data-3.2024.0305
Successfully installed mime-types-3.5.2
/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- dpl/provider/releases (LoadError)
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.16/lib/dpl/provider.rb:93:in `rescue in block in new'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.16/lib/dpl/provider.rb:68:in `block in new'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.16/lib/dpl/cli.rb:41:in `fold'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.16/lib/dpl/provider.rb:67:in `new'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.16/lib/dpl/cli.rb:31:in `run'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.16/lib/dpl/cli.rb:7:in `run'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.16/bin/dpl:5:in `<top (required)>'
	from /home/travis/.rvm/gems/ruby-2.4.1/bin/dpl:23:in `load'
	from /home/travis/.rvm/gems/ruby-2.4.1/bin/dpl:23:in `<main>'
failed to deploy

I haven't seen this issue before, I'll dig into it in the coming days, but unfortunately I'm currently blocked on deploying from travis-ci.

@smutel
Copy link
Contributor Author

smutel commented Mar 22, 2024

@aelsabbahy
Copy link
Member

Fixed by #888

I've released v0.4.6 which includes this change. Apologies for the delay, I'm on paternity leave so not on a computer often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants