Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integration tests for alpine3 #937

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Jun 21, 2024

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Apache2 has only one listener by design. Either IPv4 or IPv6.

It seems that the order of the ip addresses has been changed (in CI/docker runtime). Previously IPv4 first to now IPv6 first. If the test with Apache2 should explicitly test IPv4, the service should also explicitly run on IPv4.

Related:

@dklimpel dklimpel marked this pull request as ready for review June 21, 2024 09:17
@aelsabbahy
Copy link
Member

Yeah, I think this is related to #149

My guess is travis-ci changed that setting in their CI runners. I'm not able to reproduce that behavior on my local machine and the CI used to work just fine.. so that's my theory.

I added some debugging to my branch yesterday which showed that it was indeed listening to tcp6 here:

https://app.travis-ci.com/github/goss-org/goss/jobs/623192771#L5295

Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp        0      0 127.0.0.11:42279        0.0.0.0:*               LISTEN      -
tcp        0      0 0.0.0.0:8888            0.0.0.0:*               LISTEN      -
tcp        0      0 :::8888                 :::*                    LISTEN      -
tcp        0      0 :::80                   :::*                    LISTEN      164/httpd

This PR is the cleanest fix, so I'll merge this and close out the other ones.

Great find and thanks for the elegant fix!

@aelsabbahy aelsabbahy merged commit 3a6435f into goss-org:master Jun 21, 2024
2 checks passed
This was referenced Jun 21, 2024
@dklimpel dklimpel deleted the fix_alpine_apache_ipv4 branch June 21, 2024 15:54
@dklimpel
Copy link
Contributor Author

I had a discussion with my colleague. One alternative is to switch from Apache2 to Nginx. Nginx runs on both ports, IPv4 and IPv6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants